Support auto suggest for default values of supported data types #2352

karthikvt26 · 2019-06-07T16:31:21Z

Fix #1591

Description

Autocomplete user input on default value based on the pg data.

Affected components

Console

Related Issues

Solution and Design

Retrieves list of functions supported by postgres by applying the following filter

Fetch functions whose return type is a primitive data type like text, varchar etc,
Filter the types which belongs to Pseudo category

Infers default values of types based on their type cast target types

Steps to test and verify

Navigate to create table
Add a column called dob with column type date. The default input should provide list of suggestions
..
Navigate to modify and add/modify column

Limitations, known bugs & workarounds

…yle suggestion box

netlify · 2019-06-07T16:32:38Z

Deploy preview for hasura-docs ready!

Built with commit 58c96ee

https://deploy-preview-2352--hasura-docs.netlify.com

hasura-bot · 2019-06-07T16:51:40Z

Review app for commit c5d4eb8 deployed to Heroku: https://hge-ci-pull-2352.herokuapp.com
Docker image for server: hasura/graphql-engine:pull2352-c5d4eb88

…this info on heroku app

hasura-bot · 2019-06-08T04:41:20Z

Review app for commit 646d9aa deployed to Heroku: https://hge-ci-pull-2352.herokuapp.com
Docker image for server: hasura/graphql-engine:pull2352-646d9aad

hasura-bot · 2019-06-08T06:15:04Z

Review app for commit 0c5dd21 deployed to Heroku: https://hge-ci-pull-2352.herokuapp.com
Docker image for server: hasura/graphql-engine:pull2352-0c5dd218

hasura-bot · 2019-06-10T05:03:02Z

Review app for commit 9c4f244 deployed to Heroku: https://hge-ci-pull-2352.herokuapp.com
Docker image for server: hasura/graphql-engine:pull2352-9c4f2442

mnlbox · 2019-06-11T07:49:57Z

@karthikvt26 some fix needs in UI here:

hasura-bot · 2019-06-14T17:37:34Z

Review app for commit 3643503 deployed to Heroku: https://hge-ci-pull-2352.herokuapp.com
Docker image for server: hasura/graphql-engine:pull2352-3643503d

hasura-bot · 2019-06-14T17:53:19Z

Review app for commit 3da0bfa deployed to Heroku: https://hge-ci-pull-2352.herokuapp.com
Docker image for server: hasura/graphql-engine:pull2352-3da0bfa1

hasura-bot · 2019-06-14T18:13:20Z

Review app for commit 3b2f29c deployed to Heroku: https://hge-ci-pull-2352.herokuapp.com
Docker image for server: hasura/graphql-engine:pull2352-3b2f29ce

rikinsk-zz · 2019-06-17T12:32:52Z

console/src/components/Common/SearchableSelect/SearchableSelect.js

  value,
  bsClass,
  styleOverrides,
+  defaultPlaceholder = 'column_type',


Common component should not have a default value based on a particular use case

rikinsk-zz · 2019-06-17T12:44:52Z

console/src/components/Services/Data/Add/TableColumn.js


+  /* Collect list of relevant default values if the type doesn't have any default values
+   * */
+  const inferredDefaultValues = inferDefaultValues(


make this a function getInferredDefaultValues. setting this constant is unnecessary processing if the below ternary doesn't need it

rikinsk-zz · 2019-06-17T12:48:53Z

console/src/components/Services/Data/Add/TableDefault.js

+  getDefaultFunctionsOptions,
+} from '../Common/utils';
+
+const TableDefault = ({


rename to TableColumnDefault

rikinsk-zz · 2019-06-17T12:50:35Z

console/src/components/Services/Data/Add/TableDefault.js

+  colIndex: i,
+}) => {
+  // const styles = require('../../../Common/TableCommon/Table.scss');
+  const defaultInputTheme = require('../../../Common/CustomInputAutoSuggest/CustomInputAddTableTheme.scss');


Css file from UI component should not be used in Functional component. Move required css from common to this components css file

Here is the problem:

In order to style the auto suggest input the library owner provides multiple ways, one of the way is to use css modules since we have used it extensively everywhere.

It accepts a theme prop which basically is a compiled json object of the .scss file. Now in order to customize the css based on the requirement there is a file @ src/components/Common/CustomInputAutoSuggest/CustomInputTheme.scss which is sort of like a basic layout but it can be tweaked based on the requirement. Now inorder to do that you import it in your .scss file and modify the required properties. Should we maintain a seperate copy at each place the component is used or just move the file somewhere where it designates a common .scss file like components/Common?

@rikinsk Let me know what you think. I have fixed/added rest of the suggestions

rikinsk-zz · 2019-06-17T12:59:57Z

console/src/components/Services/Data/Add/TableDefault.js

+    const { newValue } = data;
+    onChange(i, column.nullable || false, newValue);
+  };
+  const renderDefaultHtml = () => {


rename to renderTableColumnDefaultHtml. Currently it seems like this is some default html which will be used in some particular case

rikinsk-zz · 2019-06-17T13:09:26Z

console/src/components/Services/Data/Common/utils.js

+      defaultValues[0].suggestions.push(suggestionObj);
+    }
+  });
+  /* Reversing the array just so that if frequently used types were peresent, they come first */


typo in present

rikinsk-zz · 2019-06-17T13:21:53Z

console/src/components/Services/Data/TableModify/ColumnCreator.js

    onSubmit,
  } = useColumnEditor(dispatch, tableName);

+  const defaultInputTheme = require('../../../Common/CustomInputAutoSuggest/CustomInputAddColumnTheme.scss');


Same as before. No Common Component css in Functional Component

rikinsk-zz · 2019-06-17T13:25:51Z

console/src/components/Services/Data/TableModify/ColumnCreator.js

+
+  let defaultOptions = [];
+
+  const inferredDefaultValues = inferDefaultValues(


same as before. make as function

rikinsk-zz · 2019-06-17T13:28:22Z

console/src/components/Services/Data/TableModify/ColumnEditor.js

    colName
  );

+  const defaultInputTheme = require('../../../Common/CustomInputAutoSuggest/CustomInputEditColumnTheme.scss');


same as above. move css file here

rikinsk-zz · 2019-06-17T13:41:25Z

console/src/components/Services/Data/Common/utils.js

@@ -1,8 +1,14 @@
 import { aggCategory, pgCategoryCode } from './PgInfo';

+const commonlyUsedFunctions = ['now', 'gen_random_uuid'];


add random()

hasura-bot · 2019-06-18T10:38:11Z

Review app for commit 90426ce deployed to Heroku: https://hge-ci-pull-2352.herokuapp.com
Docker image for server: hasura/graphql-engine:pull2352-90426ceb

hasura-bot · 2019-06-18T17:33:56Z

Review app https://hge-ci-pull-2352.herokuapp.com is deleted

* render 404 for nonexistent resources (hasura#2341) * update console dev logging + add logging disable instructions to README (hasura#2388) * update table rename handling (hasura#2393) * suggest column default values (hasura#2352) * fix postgres query to fetch pg_types default functions (close hasura#2399) (hasura#2402) * add graphql-voyager to console (close hasura#314) (hasura#2369) * clear header state for remote-schema (close hasura#2396) (hasura#2401) * change browse rows action buttons heading id (close hasura#2403) (hasura#2413) * created docker compose for build and launch of tutorial (hasura#2406) * fix renaming of columns used in insert permission (fix hasura#2398) (hasura#2414) * graphql2chartjs: fix mapping of non-array types (hasura#2307) * add name of ci environment to telemetry data (hasura#2382) * learn: update react native tutorial with videos (hasura#2390) * create down migration when a column is dropped (close hasura#2291) (hasura#2385) * add new column row during add table only after completed prev column def (hasura#2428) * add a make rule to build server docker image locally (hasura#2410) * learn: fix twitter share image on homepage (hasura#2437) * add note on exporting multiple schemas as migration (hasura#2436) * fix browse rows query error handling + boolean filter value (close hasura#2421) (hasura#2440) * graphql2chartjs: bump version to 0.3.0 (hasura#2445) * fix to show error notification when run sql fails in cli mode (close hasura#2438) (hasura#2446) * freeze requirements.txt for server tests (hasura#2450) * update postgres permission documentation (fix hasura#2404) (hasura#2405) * refactor AddTable validation on console (close hasura#1712) (hasura#2408) * change default type placeholder from 'text' to type (fix 2394) (hasura#2458) * add server version to console html (close hasura#2444) (hasura#2452) * fix type placeholders in console insert/edit row (hasura#2460) * fix relationship page error if array fk relationship exists with table in another schema (hasura#2459) * infer relationship type using uniqueness constraint of foreign key (close hasura#969) (hasura#2347) * use server version from console html (hasura#2464) * add schema explorer ui * wire up create API, WIP * ui fixes * integrate with proxy API * fetch remote relationships in loadSchema * fixes * finish up UI for remote rels; waiting on edit API * break relationships ui into sections * move graphql schema to local state * update relationship label * restructure * update styles; add tooltips * filter out fields (scalar type || wrapped scalar type) and do accept any args * remove an unnecessary log * version check init * add version check for remote relationship on loadSchema * use FT_REMOTE_RELATIONSHIPS * allow adding string values for scalar args * comment code * add update relationship feature * cover edge cases for update remote rel * fix semver issue where sometimes the query would never be called * remove unnecessary fields from schema tree * stable * wip * wip * wip * add version checks * invalidate remote schema cache appropriately * Remove unnecessary logs

karthikvt26 added 18 commits March 18, 2019 14:26

npm installed

e6a9400

Merge remote-tracking branch 'main/master'

2a31b3a

Merge remote-tracking branch 'main/master'

4ec7086

Merge remote-tracking branch 'main/master'

8642e67

Merge remote-tracking branch 'main/master'

8bbe6d9

Merge remote-tracking branch 'main/master'

e468763

Merge remote-tracking branch 'main/master'

aea413a

Merge remote-tracking branch 'main/master'

ede96de

Merge remote-tracking branch 'main/master'

2d5a5aa

Merge remote-tracking branch 'main/master'

7d48d49

Merge remote-tracking branch 'main/master'

2a022a3

Merge remote-tracking branch 'main/master'

719b745

Merge remote-tracking branch 'main/master'

9be15af

Merge remote-tracking branch 'main/master'

19207c4

Dispatch action to fetch most used functions

52f5573

WIP

4ed8879

Add infer default values, move fetch column casts to data actions, st…

0be2e74

…yle suggestion box

Merge remote-tracking branch 'main/master' into issue-1591

c5d4eb8

karthikvt26 added the s/do-not-merge Do not merge this pull request to master label Jun 7, 2019

Remove rolename = postgres filter as postgres doesn't allow to fetch …

646d9aa

…this info on heroku app

Add 10 sec wait before renaming: Test

0c5dd21

Check for empty object before spreading

9c4f244

Fix a css issue, cleaning up code

3643503

Update udt_name to be used to compute placeholders

3da0bfa

karthikvt26 removed the s/do-not-merge Do not merge this pull request to master label Jun 14, 2019

karthikvt26 marked this pull request as ready for review June 14, 2019 17:53

karthikvt26 requested a review from rikinsk-zz as a code owner June 14, 2019 17:53

Merge remote-tracking branch 'main/master' into issue-1591

3b2f29c

rikinsk-zz added the c/console Related to console label Jun 16, 2019

rikinsk-zz reviewed Jun 17, 2019

View reviewed changes

Fix based on suggestions/feedback

90426ce

rikinsk added 3 commits June 18, 2019 19:10

.

0b5f32a

Merge branch 'master' into issue-1591

55abcb5

Merge branch 'master' into issue-1591

58c96ee

rikinsk-zz approved these changes Jun 18, 2019

View reviewed changes

rikinsk-zz merged commit 93a7c2c into hasura:master Jun 18, 2019

polRk pushed a commit to polRk/graphql-engine that referenced this pull request Feb 12, 2020

suggest column default values (hasura#2352)

ee9fd0a


		let defaultOptions = [];

		const inferredDefaultValues = inferDefaultValues(

		@@ -1,8 +1,14 @@
		import { aggCategory, pgCategoryCode } from './PgInfo';

		const commonlyUsedFunctions = ['now', 'gen_random_uuid'];

Support auto suggest for default values of supported data types #2352

Support auto suggest for default values of supported data types #2352

Uh oh!

Conversation

karthikvt26 commented Jun 7, 2019

Description

Affected components

Related Issues

Solution and Design

Steps to test and verify

Limitations, known bugs & workarounds

Uh oh!

netlify bot commented Jun 7, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

hasura-bot commented Jun 7, 2019

Uh oh!

hasura-bot commented Jun 8, 2019

Uh oh!

hasura-bot commented Jun 8, 2019

Uh oh!

hasura-bot commented Jun 10, 2019

Uh oh!

mnlbox commented Jun 11, 2019

Uh oh!

hasura-bot commented Jun 14, 2019

Uh oh!

hasura-bot commented Jun 14, 2019

Uh oh!

hasura-bot commented Jun 14, 2019

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

karthikvt26 Jun 17, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

hasura-bot commented Jun 18, 2019

Uh oh!

hasura-bot commented Jun 18, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

netlify bot commented Jun 7, 2019 •

edited

Loading

karthikvt26 Jun 17, 2019 •

edited

Loading