这是indexloc提供的服务，不要输入任何密码
Skip to content

add About page in console #2334

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 19 commits into from
Jul 29, 2019
Merged

add About page in console #2334

merged 19 commits into from
Jul 29, 2019

Conversation

@strongSoda
Copy link
Contributor

@strongSoda strongSoda commented Jun 5, 2019 •
edited by rikinsk-zz
Loading

Description

Add an About page under ?

Display:

  • Current server version
  • Latest server version available
  • Console asset version

Affected components

  • Console

@strongSoda strongSoda added k/enhancement New feature or improve an existing feature c/console Related to console labels Jun 5, 2019
@strongSoda strongSoda requested a review from rikinsk-zz as a code owner June 5, 2019 10:52
@netlify
Copy link

netlify bot commented Jun 5, 2019 •
edited
Loading

Deploy preview for hasura-docs ready!

Built with commit b426a28

https://deploy-preview-2334--hasura-docs.netlify.com

@hasura-bot
Copy link
Contributor

hasura-bot commented Jun 5, 2019

Review app for commit dd3eda7 deployed to Heroku: https://hge-ci-pull-2334.herokuapp.com
Docker image for server: hasura/graphql-engine:pull2334-dd3eda7e

@mnlbox
Copy link
Contributor

mnlbox commented Jun 5, 2019

@strongSoda Maybe merge About page with Metadata Status is better 🤔

@strongSoda
Copy link
Contributor Author

strongSoda commented Jun 5, 2019

@mnlbox About page is to keep a reference of versions. Metadata status' purpose is to signify whether it's consistent or not without showing I guess.

@hasura-bot
Copy link
Contributor

hasura-bot commented Jun 6, 2019

Review app for commit 5ae5030 deployed to Heroku: https://hge-ci-pull-2334.herokuapp.com
Docker image for server: hasura/graphql-engine:pull2334-5ae50301

@hasura-bot
Copy link
Contributor

hasura-bot commented Jun 17, 2019

Review app for commit 6239a06 deployed to Heroku: https://hge-ci-pull-2334.herokuapp.com
Docker image for server: hasura/graphql-engine:pull2334-6239a06e

@strongSoda strongSoda requested a review from shahidhk as a code owner June 17, 2019 09:40
@hasura-bot
Copy link
Contributor

hasura-bot commented Jun 17, 2019

Review app for commit 9f2c2fa deployed to Heroku: https://hge-ci-pull-2334.herokuapp.com
Docker image for server: hasura/graphql-engine:pull2334-9f2c2fab

@strongSoda strongSoda added the c/cli Related to CLI label Jun 17, 2019
@hasura-bot
Copy link
Contributor

hasura-bot commented Jun 17, 2019

Review app for commit 43559ba deployed to Heroku: https://hge-ci-pull-2334.herokuapp.com
Docker image for server: hasura/graphql-engine:pull2334-43559ba5

@hasura-bot
Copy link
Contributor

hasura-bot commented Jun 17, 2019

Review app for commit f4faa8a deployed to Heroku: https://hge-ci-pull-2334.herokuapp.com
Docker image for server: hasura/graphql-engine:pull2334-f4faa8ab

@mnlbox
Copy link
Contributor

mnlbox commented Jun 24, 2019

@strongSoda for me console asset version not display. Is it finished?
Screenshot from 2019-06-24 08-32-42

@strongSoda
Copy link
Contributor Author

strongSoda commented Jun 24, 2019

The console part where it's embedded and fetched is finished. The value has to come from the assets cdn.

@rikinsk-zz rikinsk-zz self-assigned this Jun 27, 2019
@rikinsk-zz rikinsk-zz added e/easy can be wrapped up in a couple of days e/quickfix can be wrapped up in few hours and removed e/easy can be wrapped up in a couple of days labels Jun 27, 2019
@hasura-bot
Copy link
Contributor

hasura-bot commented Jul 25, 2019

Review app for commit 806ae1e deployed to Heroku: https://hge-ci-pull-2334.herokuapp.com
Docker image for server: hasura/graphql-engine:pull2334-806ae1e5

@hasura-bot
Copy link
Contributor

hasura-bot commented Jul 25, 2019

Review app for commit 37385f8 deployed to Heroku: https://hge-ci-pull-2334.herokuapp.com
Docker image for server: hasura/graphql-engine:pull2334-37385f8b

@hasura-bot
Copy link
Contributor

hasura-bot commented Jul 26, 2019

Review app for commit 46825fc deployed to Heroku: https://hge-ci-pull-2334.herokuapp.com
Docker image for server: hasura/graphql-engine:pull2334-46825fc5

@hasura-bot
Copy link
Contributor

hasura-bot commented Jul 28, 2019

Review app for commit 8443339 deployed to Heroku: https://hge-ci-pull-2334.herokuapp.com
Docker image for server: hasura/graphql-engine:pull2334-84433399

@hasura-bot
Copy link
Contributor

hasura-bot commented Jul 29, 2019

Review app for commit 1408160 deployed to Heroku: https://hge-ci-pull-2334.herokuapp.com
Docker image for server: hasura/graphql-engine:pull2334-14081606

rikinsk-zz
rikinsk-zz previously approved these changes Jul 29, 2019
View reviewed changes
@rikinsk-zz rikinsk-zz removed the c/cli Related to CLI label Jul 29, 2019
rikinsk-zz
rikinsk-zz previously approved these changes Jul 29, 2019
View reviewed changes
@hasura-bot
Copy link
Contributor

hasura-bot commented Jul 29, 2019

Review app for commit f33ca98 deployed to Heroku: https://hge-ci-pull-2334.herokuapp.com
Docker image for server: hasura/graphql-engine:pull2334-f33ca980

@hasura-bot
Copy link
Contributor

hasura-bot commented Jul 29, 2019

Review app for commit b426a28 deployed to Heroku: https://hge-ci-pull-2334.herokuapp.com
Docker image for server: hasura/graphql-engine:pull2334-b426a281

@rikinsk-zz rikinsk-zz merged commit 4aef5b4 into hasura:master Jul 29, 2019
@hasura-bot
Copy link
Contributor

hasura-bot commented Jul 29, 2019

Review app https://hge-ci-pull-2334.herokuapp.com is deleted

polRk pushed a commit to polRk/graphql-engine that referenced this pull request Feb 12, 2020
@strongSoda @polRk
add About page to console to show versions info (hasura#2334)
753b1d8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@shahidhk shahidhk Awaiting requested review from shahidhk

1 more reviewer

@rikinsk-zz rikinsk-zz rikinsk-zz approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@rikinsk-zz rikinsk-zz

Labels

c/console Related to console e/quickfix can be wrapped up in few hours k/enhancement New feature or improve an existing feature

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@strongSoda @hasura-bot @mnlbox @rikinsk-zz @rikinsk