Enable add/modify/delete for event triggers and remote schemas in migration mode, fix #1875 #2366
Conversation
Fix 1875, enabling modification of Event Triggers and Remote Schemas when migration mode is on.
|
Deploy preview for hasura-docs ready! Built with commit 56b9936 |
|
Review app for commit 0308891 deployed to Heroku: https://hge-ci-pull-2366.herokuapp.com |
|
Review app for commit cf0857c deployed to Heroku: https://hge-ci-pull-2366.herokuapp.com |
|
Review app https://hge-ci-pull-2366.herokuapp.com is deleted |
|
Review app for commit 56b9936 deployed to Heroku: https://hge-ci-pull-2366.herokuapp.com |
|
@arvi3411301 this review app is not deleted even after the PR is merged. FYI. |
|
@wawhal This is because the PR was merged even before the review app was deployed for the status check. |
…abled migration mode (fix hasura#1875) (hasura#2366)
Description
User will now see controls for add/modify/delete event triggers and remote schemas when in migration mode.
Affected components
Related Issues
close #1875
Solution and Design
Removed check for migrationmode when not needed
Steps to test and verify
set migration mode on,
visit the events trigger page, add a simple event trigger, modify it, then delete it
visit the remote schemas page, use the Glitch example to make a remote schema,
modify it, and delete it.
visit the Data page and see that you can't modify the DDL
Limitations, known bugs & workarounds
You can still trick the system by entering SQL