这是indexloc提供的服务，不要输入任何密码
Skip to content

forward cookie headers from remote servers (fix #1654) #2305

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 16 commits into from
Jun 4, 2019
Merged

forward cookie headers from remote servers (fix #1654) #2305

merged 16 commits into from
Jun 4, 2019

Conversation

@ecthiender
Copy link
Contributor

@ecthiender ecthiender commented May 30, 2019 •
edited
Loading

Description

Forward only Set-Cookie header received from remote schema servers, to client.

Note: This won't send back any remote response headers when the websocket transport is used.

Affected components

  • Server
  • Tests

Related Issues

#1654

Solution and Design

Introduced new data type HttpResponse which encapsulates headers and some response body. Changed corresponding handlers. It only sends Set-Cookie header from remote.

Steps to test and verify

  1. Add a remote schema which returns say Set-Cookie header
  2. Make a remote schema query
  3. Observe if the cookie is set in the browser

Limitations, known bugs & workarounds

@ecthiender
forward response headers from remote servers (fix hasura#1654)
8771582
@ecthiender
add note in docs about response headers over websocket
3e00374
@ecthiender
send admin secret headers in tests
74af57d
@ecthiender
wrap hasura's response and text headers in newtype
c6b6973
@ecthiender
use hashset in http headers static list
240bd4d
@ecthiender
dumb mistake of missing a negation
a063feb
@ecthiender
Merge branch 'fix-1654-fwd-resp-hdrs' into fix-1654-fwd-remote-resp-h…
d683f5d 
…eaders

Resolve Conflicts:
  docs/graphql/manual/remote-schemas/index.rst
  server/src-lib/Hasura/GraphQL/Transport/HTTP.hs
  server/src-lib/Hasura/GraphQL/Transport/WebSocket.hs
  server/src-lib/Hasura/Server/App.hs
  server/src-lib/Hasura/Server/Auth.hs
  server/src-lib/Hasura/Server/Utils.hs
  server/tests-py/graphql_server.py
@ecthiender
forward response headers from remote servers to client
d597036
@ecthiender ecthiender added the c/server Related to server label May 30, 2019
@netlify
Copy link

netlify bot commented May 30, 2019 •
edited
Loading

Deploy preview for hasura-docs ready!

Built with commit 037269f

https://deploy-preview-2305--hasura-docs.netlify.com

@hasura-bot
Copy link
Contributor

hasura-bot commented May 30, 2019

Review app for commit d597036 deployed to Heroku: https://hge-ci-pull-2305.herokuapp.com
Docker image for server: hasura/graphql-engine:pull2305-d5970362

@ecthiender ecthiender added the s/ok-to-merge Status: This pull request can be merged to master label May 30, 2019
@hasura-bot
Copy link
Contributor

hasura-bot commented May 30, 2019

Review app for commit 2905435 deployed to Heroku: https://hge-ci-pull-2305.herokuapp.com
Docker image for server: hasura/graphql-engine:pull2305-29054350

@ecthiender ecthiender changed the title forward response headers from remote servers (fix #1654) forward cookie headers from remote servers (fix #1654) May 31, 2019
@hasura-bot
Copy link
Contributor

hasura-bot commented May 31, 2019

Review app for commit 626c222 deployed to Heroku: https://hge-ci-pull-2305.herokuapp.com
Docker image for server: hasura/graphql-engine:pull2305-626c222c

0x777
0x777 reviewed Jun 3, 2019
View reviewed changes
@hasura-bot
Copy link
Contributor

hasura-bot commented Jun 3, 2019

Review app for commit 098410a deployed to Heroku: https://hge-ci-pull-2305.herokuapp.com
Docker image for server: hasura/graphql-engine:pull2305-098410af

0x777
0x777 previously approved these changes Jun 3, 2019
View reviewed changes
@hasura-bot
Copy link
Contributor

hasura-bot commented Jun 3, 2019

Review app for commit 59cd120 deployed to Heroku: https://hge-ci-pull-2305.herokuapp.com
Docker image for server: hasura/graphql-engine:pull2305-59cd120a

@ecthiender ecthiender self-assigned this Jun 4, 2019
@hasura-bot
Copy link
Contributor

hasura-bot commented Jun 4, 2019

Review app for commit 037269f deployed to Heroku: https://hge-ci-pull-2305.herokuapp.com
Docker image for server: hasura/graphql-engine:pull2305-037269f2

@0x777 0x777 merged commit 278f26b into hasura:master Jun 4, 2019
@hasura-bot
Copy link
Contributor

hasura-bot commented Jun 4, 2019

Review app https://hge-ci-pull-2305.herokuapp.com is deleted

@fpieper fpieper mentioned this pull request Jan 30, 2020
Closed
polRk pushed a commit to polRk/graphql-engine that referenced this pull request Feb 12, 2020
@ecthiender @polRk
forward set-cookie headers from remote servers (fix hasura#1654) (has…
6bc5ef1 
…ura#2305)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@0x777 0x777 0x777 approved these changes

@rikinsk-zz rikinsk-zz Awaiting requested review from rikinsk-zz

Assignees

@ecthiender ecthiender

Labels

c/server Related to server s/ok-to-merge Status: This pull request can be merged to master

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ecthiender @hasura-bot @0x777