这是indexloc提供的服务，不要输入任何密码
Skip to content

fix: head to home console error from error page #2304

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
May 31, 2019
Merged

fix: head to home console error from error page #2304

merged 4 commits into from
May 31, 2019

Conversation

@strongSoda
Copy link
Contributor

@strongSoda strongSoda commented May 30, 2019

Affected components

  • Console

@strongSoda strongSoda requested a review from rikinsk-zz as a code owner May 30, 2019 12:58
@hasura-bot
Copy link
Contributor

hasura-bot commented May 30, 2019

Beep boop! 🤖

Hey @strongSoda, thanks for your PR!

One of my human friends will review this PR and get back to you as soon as possible. 🕐

Stay awesome! 😎

@netlify
Copy link

netlify bot commented May 30, 2019 •
edited
Loading

Deploy preview for hasura-docs ready!

Built with commit be6c40d

https://deploy-preview-2304--hasura-docs.netlify.com

@strongSoda strongSoda added c/console Related to console k/bug Something isn't working labels May 30, 2019
@hasura-bot
Copy link
Contributor

hasura-bot commented May 30, 2019

Review app for commit bcb6bac deployed to Heroku: https://hge-ci-pull-2304.herokuapp.com
Docker image for server: hasura/graphql-engine:pull2304-bcb6bac5

rikinsk-zz
rikinsk-zz suggested changes May 30, 2019
View reviewed changes
Copy link

@rikinsk-zz rikinsk-zz left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@strongSoda using window.location.replace causes a hard refresh to happen (refetch of all state data again). To avoid that we use the <Link> react component to do routing.
Instead

  • create a func called resetState which does this.setState({ hasError: false, info: null, error: null })
  • add an onClick={resetState} to the Link
  • replace other places in the file that are doing the same thing with resetState (line 25)

@strongSoda
Copy link
Contributor Author

strongSoda commented May 30, 2019 •
edited
Loading

doing this renders the 404 page after clicking on home link.

@strongSoda strongSoda requested a review from rikinsk-zz May 31, 2019 12:10
@hasura-bot
Copy link
Contributor

hasura-bot commented May 31, 2019

Review app for commit 089c882 deployed to Heroku: https://hge-ci-pull-2304.herokuapp.com
Docker image for server: hasura/graphql-engine:pull2304-089c8829

@rikinsk-zz rikinsk-zz merged commit 17b5dc0 into hasura:master May 31, 2019
@hasura-bot
Copy link
Contributor

hasura-bot commented May 31, 2019

Review app https://hge-ci-pull-2304.herokuapp.com is deleted

@hasura-bot
Copy link
Contributor

hasura-bot commented May 31, 2019

Beep boop! 🤖

Whoa! 🎉 🎉 💃

GIF

Awesome work @strongSoda! 💪 🏆 All of us at Hasura ❤️ what you did.

Thanks again 🤗

@strongSoda strongSoda deleted the homeError branch June 3, 2019 06:39
polRk pushed a commit to polRk/graphql-engine that referenced this pull request Feb 12, 2020
@strongSoda @polRk
fix head to home console error from error page (hasura#2304)
796c5c9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@rikinsk-zz rikinsk-zz rikinsk-zz approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

c/console Related to console k/bug Something isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@strongSoda @hasura-bot @rikinsk-zz @rikinsk