这是indexloc提供的服务，不要输入任何密码
Skip to content

support null and default values for function input arguments (close #2176, #2250) #2282

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Jun 4, 2019
Merged

support null and default values for function input arguments (close #2176, #2250) #2282

merged 7 commits into from
Jun 4, 2019

Conversation

@rakeshkky
Copy link
Member

@rakeshkky rakeshkky commented May 27, 2019

Description

Support null and default values for input argument in args field for SQL function query

Affected components

  • Server
  • Tests

Related Issues

close #2250 , #2176

Solution and Design

  • Make input fields in args object as nullable
  • Execute function with SQL NULL value for an argument whose GraphQL value is null
  • Omit the input argument if it is not given so that Postgres uses it's default value if defined

Steps to test and verify

  • Define a function with default input arguments
  • Query the function in GraphQL with the omission of default arguments
  • The function should return results evaluated with default values

rakeshkky added 3 commits May 27, 2019 13:04
@rakeshkky
support nullable inputs for SQL function args, close hasura#2176, has…
d48a4bd 
…ura#2250

=> If a parameter is not provided, it's default value is considered in
SQL function
=> If a parameter is provided with 'null' value, then SQL function
executed with 'NULL' value
@rakeshkky
add a test case to test null and default values to functions
cf81419
@rakeshkky
add docs
6e8abec
@rakeshkky rakeshkky added s/ok-to-merge Status: This pull request can be merged to master c/server Related to server labels May 27, 2019
@rakeshkky rakeshkky self-assigned this May 27, 2019
@netlify
Copy link

netlify bot commented May 27, 2019 •
edited
Loading

Deploy preview for hasura-docs ready!

Built with commit f0dc399

https://deploy-preview-2282--hasura-docs.netlify.com

@hasura-bot
Copy link
Contributor

hasura-bot commented May 27, 2019

Review app for commit 6e8abec deployed to Heroku: https://hge-ci-pull-2282.herokuapp.com
Docker image for server: hasura/graphql-engine:pull2282-6e8abec2

@hasura-bot
Copy link
Contributor

hasura-bot commented May 29, 2019

Review app for commit 61ff741 deployed to Heroku: https://hge-ci-pull-2282.herokuapp.com
Docker image for server: hasura/graphql-engine:pull2282-61ff741c

0x777
0x777 previously approved these changes Jun 4, 2019
View reviewed changes
@hasura-bot
Copy link
Contributor

hasura-bot commented Jun 4, 2019

Review app for commit f1dbe4b deployed to Heroku: https://hge-ci-pull-2282.herokuapp.com
Docker image for server: hasura/graphql-engine:pull2282-f1dbe4b1

@hasura-bot
Copy link
Contributor

hasura-bot commented Jun 4, 2019

Review app for commit 8f9fb74 deployed to Heroku: https://hge-ci-pull-2282.herokuapp.com
Docker image for server: hasura/graphql-engine:pull2282-8f9fb748

0x777
0x777 previously approved these changes Jun 4, 2019
View reviewed changes
rikinsk-zz
rikinsk-zz approved these changes Jun 4, 2019
View reviewed changes
Copy link

@rikinsk-zz rikinsk-zz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved docs

@hasura-bot
Copy link
Contributor

hasura-bot commented Jun 4, 2019

Review app for commit f0dc399 deployed to Heroku: https://hge-ci-pull-2282.herokuapp.com
Docker image for server: hasura/graphql-engine:pull2282-f0dc399b

@0x777 0x777 merged commit c3c01be into hasura:master Jun 4, 2019
@hasura-bot
Copy link
Contributor

hasura-bot commented Jun 4, 2019

Review app https://hge-ci-pull-2282.herokuapp.com is deleted

polRk pushed a commit to polRk/graphql-engine that referenced this pull request Feb 12, 2020
@rakeshkky @polRk
support null and default values for function arguments (close hasura#…
ecdd9fe 
…2176, close hasura#2250) (hasura#2282)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@0x777 0x777 0x777 approved these changes

+1 more reviewer

@rikinsk-zz rikinsk-zz rikinsk-zz approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@rakeshkky rakeshkky

Labels

c/server Related to server s/ok-to-merge Status: This pull request can be merged to master

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

How to pass NULL to a function?

5 participants

@rakeshkky @hasura-bot @rikinsk-zz @0x777 @rikinsk