这是indexloc提供的服务，不要输入任何密码
Skip to content

update console favicons to png #2287

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
May 29, 2019
Merged

update console favicons to png #2287

merged 5 commits into from
May 29, 2019

Conversation

@rikinsk-zz
Copy link

@rikinsk-zz rikinsk-zz commented May 28, 2019 •
edited
Loading

Description

Affected components

  • Server
  • Console
  • CLI

Related Issues

Solution and Design

Steps to test and verify

  • server console cdn
  • server console local
  • cli console

Limitations, known bugs & workarounds

@rikinsk-zz rikinsk-zz requested a review from shahidhk May 28, 2019 07:31
@rikinsk-zz rikinsk-zz requested a review from 0x777 as a code owner May 28, 2019 07:31
@netlify
Copy link

netlify bot commented May 28, 2019 •
edited
Loading

Deploy preview for hasura-docs ready!

Built with commit c97adb5

https://deploy-preview-2287--hasura-docs.netlify.com

@hasura-bot
Copy link
Contributor

hasura-bot commented May 28, 2019

Review app for commit fcd1d0a deployed to Heroku: https://hge-ci-pull-2287.herokuapp.com
Docker image for server: hasura/graphql-engine:pull2287-fcd1d0a5

@rikinsk-zz rikinsk-zz added the s/do-not-merge Do not merge this pull request to master label May 28, 2019
@shahidhk
Copy link
Member

shahidhk commented May 28, 2019

/heroku deploy

@hasura-bot
Copy link
Contributor

hasura-bot commented May 28, 2019

Review app for commit c97adb5 deployed to Heroku: https://hge-ci-pull-2287.herokuapp.com
Docker image for server: hasura/graphql-engine:pull2287-c97adb5d

@rikinsk-zz rikinsk-zz added s/ok-to-merge Status: This pull request can be merged to master and removed s/do-not-merge Do not merge this pull request to master labels May 28, 2019
@shahidhk shahidhk added the c/console Related to console label May 29, 2019
shahidhk
shahidhk approved these changes May 29, 2019
View reviewed changes
Copy link
Member

@shahidhk shahidhk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shahidhk shahidhk merged commit 7ab9d5e into hasura:master May 29, 2019
@hasura-bot
Copy link
Contributor

hasura-bot commented May 29, 2019

Review app https://hge-ci-pull-2287.herokuapp.com is deleted

@rikinsk-zz rikinsk-zz deleted the console-favicons branch July 26, 2019 07:47
polRk pushed a commit to polRk/graphql-engine that referenced this pull request Feb 12, 2020
@rikinsk @polRk
update console favicons to png (hasura#2287)
99dce7d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@shahidhk shahidhk shahidhk approved these changes

@0x777 0x777 Awaiting requested review from 0x777

Assignees

No one assigned

Labels

c/console Related to console s/ok-to-merge Status: This pull request can be merged to master

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@rikinsk-zz @hasura-bot @shahidhk @rikinsk