这是indexloc提供的服务,不要输入任何密码
Skip to content

Conversation

@rikinsk-zz
Copy link

@rikinsk-zz rikinsk-zz commented May 28, 2019

Description

Affected components

  • Server
  • Console
  • CLI

Related Issues

Solution and Design

Steps to test and verify

  • server console cdn
  • server console local
  • cli console

Limitations, known bugs & workarounds

@rikinsk-zz rikinsk-zz requested a review from shahidhk May 28, 2019 07:31
@rikinsk-zz rikinsk-zz requested a review from 0x777 as a code owner May 28, 2019 07:31
@netlify
Copy link

netlify bot commented May 28, 2019

Deploy preview for hasura-docs ready!

Built with commit c97adb5

https://deploy-preview-2287--hasura-docs.netlify.com

@hasura-bot
Copy link
Contributor

Review app for commit fcd1d0a deployed to Heroku: https://hge-ci-pull-2287.herokuapp.com
Docker image for server: hasura/graphql-engine:pull2287-fcd1d0a5

@rikinsk-zz rikinsk-zz added the s/do-not-merge Do not merge this pull request to master label May 28, 2019
@shahidhk
Copy link
Member

/heroku deploy

@hasura-bot
Copy link
Contributor

Review app for commit c97adb5 deployed to Heroku: https://hge-ci-pull-2287.herokuapp.com
Docker image for server: hasura/graphql-engine:pull2287-c97adb5d

@rikinsk-zz rikinsk-zz added s/ok-to-merge Status: This pull request can be merged to master and removed s/do-not-merge Do not merge this pull request to master labels May 28, 2019
@shahidhk shahidhk added the c/console Related to console label May 29, 2019
Copy link
Member

@shahidhk shahidhk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shahidhk shahidhk merged commit 7ab9d5e into hasura:master May 29, 2019
@hasura-bot
Copy link
Contributor

Review app https://hge-ci-pull-2287.herokuapp.com is deleted

@rikinsk-zz rikinsk-zz deleted the console-favicons branch July 26, 2019 07:47
polRk pushed a commit to polRk/graphql-engine that referenced this pull request Feb 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c/console Related to console s/ok-to-merge Status: This pull request can be merged to master

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants