这是indexloc提供的服务，不要输入任何密码
Skip to content

fix console left sidebar flashing issue #2286

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
May 29, 2019
Merged

fix console left sidebar flashing issue #2286

merged 11 commits into from
May 29, 2019

Conversation

@arvi3411301
Copy link
Member

@arvi3411301 arvi3411301 commented May 27, 2019

Description

Affected components

  • Console

Related Issues

Solution and Design

Steps to test and verify

Limitations, known bugs & workarounds

@arvi3411301 arvi3411301 requested a review from rikinsk-zz May 27, 2019 22:15
@netlify
Copy link

netlify bot commented May 27, 2019 •
edited
Loading

Deploy preview for hasura-docs ready!

Built with commit ad408fd

https://deploy-preview-2286--hasura-docs.netlify.com

@hasura-bot
Copy link
Contributor

hasura-bot commented May 27, 2019

Review app for commit 2ddb573 deployed to Heroku: https://hge-ci-pull-2286.herokuapp.com
Docker image for server: hasura/graphql-engine:pull2286-2ddb573b

@hasura-bot
Copy link
Contributor

hasura-bot commented May 27, 2019

Review app for commit 87dd9e1 deployed to Heroku: https://hge-ci-pull-2286.herokuapp.com
Docker image for server: hasura/graphql-engine:pull2286-87dd9e11

@mnlbox
Copy link
Contributor

mnlbox commented May 28, 2019

@arvi3411301 can you explain this issue?
Because I find another flashing issue on schema drop down that still exist in your PR. Is it related? 🤔

@rikinsk-zz rikinsk-zz added the c/console Related to console label May 28, 2019
@arvi3411301 arvi3411301 marked this pull request as ready for review May 28, 2019 18:08
@mnlbox
Copy link
Contributor

mnlbox commented May 29, 2019

@arvi3411301 This flashing still exist.
Peek 2019-05-29 09-41

/CC: @wawhal

@wawhal
Copy link
Contributor

wawhal commented May 29, 2019

@mnlbox we will fix it in another PR :)
Thanks for reporting.

@hasura-bot
Copy link
Contributor

hasura-bot commented May 29, 2019

Review app for commit 794bc5c deployed to Heroku: https://hge-ci-pull-2286.herokuapp.com
Docker image for server: hasura/graphql-engine:pull2286-794bc5cf

@hasura-bot
Copy link
Contributor

hasura-bot commented May 29, 2019

Review app for commit a736837 deployed to Heroku: https://hge-ci-pull-2286.herokuapp.com
Docker image for server: hasura/graphql-engine:pull2286-a7368379

@hasura-bot
Copy link
Contributor

hasura-bot commented May 29, 2019

Review app for commit 3541fe4 deployed to Heroku: https://hge-ci-pull-2286.herokuapp.com
Docker image for server: hasura/graphql-engine:pull2286-3541fe4f

@hasura-bot
Copy link
Contributor

hasura-bot commented May 29, 2019

Review app for commit 534497d deployed to Heroku: https://hge-ci-pull-2286.herokuapp.com
Docker image for server: hasura/graphql-engine:pull2286-534497d2

@rikinsk-zz rikinsk-zz merged commit f9fc0cc into hasura:master May 29, 2019
@hasura-bot
Copy link
Contributor

hasura-bot commented May 29, 2019

Review app https://hge-ci-pull-2286.herokuapp.com is deleted

@arvi3411301 arvi3411301 deleted the fix-console-sidebar branch May 29, 2019 14:19
@hasura-bot
Copy link
Contributor

hasura-bot commented May 29, 2019

Review app for commit ad408fd deployed to Heroku: https://hge-ci-pull-2286.herokuapp.com
Docker image for server: hasura/graphql-engine:pull2286-ad408fd8

polRk pushed a commit to polRk/graphql-engine that referenced this pull request Feb 12, 2020
@arvi3411301 @polRk
fix console schema update quirks (hasura#2286)
41914b3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@rikinsk-zz rikinsk-zz rikinsk-zz approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

c/console Related to console

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@arvi3411301 @hasura-bot @mnlbox @wawhal @rikinsk-zz @rikinsk