这是indexloc提供的服务，不要输入任何密码
Skip to content

match Q.Serializable tx isolation to serializable setting #2211

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 20, 2019
Merged

match Q.Serializable tx isolation to serializable setting #2211

merged 2 commits into from
May 20, 2019

Conversation

@joshainglis
Copy link
Contributor

@joshainglis joshainglis commented May 17, 2019

Description

Ensure Serializable transaction isolation is set when 'serializable' setting is provided

Affected components

  • Server

@joshainglis joshainglis requested a review from 0x777 as a code owner May 17, 2019 09:30
@hasura-bot
Copy link
Contributor

hasura-bot commented May 17, 2019

Beep boop! 🤖

Hey @joshainglis, thanks for your PR!

One of my human friends will review this PR and get back to you as soon as possible. 🕐

Stay awesome! 😎

@netlify
Copy link

netlify bot commented May 17, 2019 •
edited
Loading

Deploy preview for hasura-docs ready!

Built with commit 7dd2e09

https://deploy-preview-2211--hasura-docs.netlify.com

@ecthiender
Copy link
Contributor

ecthiender commented May 17, 2019

@joshainglis you can maybe merge your other PR (#2210) into this? As they are small changes, easier to review and merge it together.

@ecthiender ecthiender added the c/server Related to server label May 17, 2019
@joshainglis
fix transaction isolation settings
a515fe9 
* spelling fix: read-comitted -> read-committed
* match Q.Serializable tx isolation to serializable setting
@joshainglis joshainglis mentioned this pull request May 17, 2019
Closed
@joshainglis
Copy link
Contributor Author

joshainglis commented May 17, 2019

Thanks @ecthiender. Merged it in.

@hasura-bot
Copy link
Contributor

hasura-bot commented May 17, 2019

Review app for commit a515fe9 deployed to Heroku: https://hge-ci-pull-2211.herokuapp.com
Docker image for server: hasura/graphql-engine:pull2211-a515fe98

@hasura-bot
Copy link
Contributor

hasura-bot commented May 20, 2019

Review app for commit 7dd2e09 deployed to Heroku: https://hge-ci-pull-2211.herokuapp.com
Docker image for server: hasura/graphql-engine:pull2211-7dd2e099

rakeshkky
rakeshkky approved these changes May 20, 2019
View reviewed changes
Copy link
Member

@rakeshkky rakeshkky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shahidhk shahidhk merged commit 277be90 into hasura:master May 20, 2019
@hasura-bot
Copy link
Contributor

hasura-bot commented May 20, 2019

Beep boop! 🤖

Whoa! 🎉 🎉 💃

GIF

Awesome work @joshainglis! 💪 🏆 All of us at Hasura ❤️ what you did.

Thanks again 🤗

@hasura-bot
Copy link
Contributor

hasura-bot commented May 20, 2019

Review app https://hge-ci-pull-2211.herokuapp.com is deleted

@joshainglis joshainglis deleted the tx-isolation-fix branch May 20, 2019 14:26
polRk pushed a commit to polRk/graphql-engine that referenced this pull request Feb 12, 2020
@joshainglis @polRk
fix transaction isolation settings on server (hasura#2211)
75ca465
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@0x777 0x777 0x777 approved these changes

@rakeshkky rakeshkky rakeshkky approved these changes

Assignees

No one assigned

Labels

c/server Related to server

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@joshainglis @hasura-bot @ecthiender @0x777 @rakeshkky @shahidhk