modify comments for tables/columns and views #220
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@arvi3411301 review app for this pr? |
|
@karthikvt26 status check for server changed from test_and_build_server to build_server. @shahidhk can we change it back to test_and_build_server? |
|
Review app available at: https://hge-ci-pull-220.herokuapp.com |
|
@praveenweb I tested the following usecases
While creating table I encountered a tiny css issue
Let me know |
|
Review app available at: https://hge-ci-pull-220.herokuapp.com |
karthikvt26
approved these changes
Jul 30, 2018
| if (state.tableComment && state.tableComment !== '') { | ||
| sqlCreateTable += | ||
| ' COMMENT ON TABLE ' + | ||
| currentSchema + |
|
Review app https://hge-ci-pull-220.herokuapp.com is deleted |
|
/heroku deploy |
|
Review app available at: https://hge-ci-pull-220.herokuapp.com |
|
/heroku delete |
|
Review app https://hge-ci-pull-220.herokuapp.com is deleted |
|
/heroku deploy |
|
@arpit4 you don't have enough permissions to execute this command |
shahidhk
pushed a commit
that referenced
this pull request
Dec 21, 2019
polRk
pushed a commit
to polRk/graphql-engine
that referenced
this pull request
Feb 12, 2020
hgiasac
pushed a commit
to hgiasac/graphql-engine
that referenced
this pull request
Dec 19, 2023
GitOrigin-RevId: e78e8f7f2810b0b1ef7a34cd7aace49c1e559a8c
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.