bundle console assets into server (close #516, close #521, close #2130) #2192
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nto console-assets
|
Deploy preview for hasura-docs ready! Built with commit 302adba |
shahidhk
commented
May 15, 2019
0x777
reviewed
May 15, 2019
0x777
approved these changes
May 15, 2019
Contributor
|
Review app https://hge-ci-pull-2192.herokuapp.com is deleted |
Contributor
|
@shahidhk Based on this PR we need download asset file or use another docker image? |
polRk
pushed a commit
to polRk/graphql-engine
that referenced
this pull request
Feb 12, 2020
…close hasura#2130) (hasura#2192) This PR builds console static assets into the server docker image at `/srv/console-assets`. When env var `HASURA_GRAPHQL_CONSOLE_ASSETS_DIR=/srv/console-assets` or flag `--console-assets-dir=/srv/console-assets` is set on the server, the files in this directory are served at `/console/assets/*`. The console html template will have a variable called `cdnAssets: false` when this flag is set and it loads assets from server itself instead of CDN. The assets are moved to a new bucket with a new naming scheme: ``` graphql-engine-cdn.hasura.io/console/assets/ /common/{} /versioned/<version/{} /channel/<channel>/<version>/{} ``` Console served by CLI will still load assets from CDN - will fix that in the next release.
hasura-bot
pushed a commit
that referenced
this pull request
Sep 22, 2025
…ip (#2192) The LHS headers were getting lost, keep them. V3_GIT_ORIGIN_REV_ID: 1dea4b42fb66a39700cab2559d171e7bc11cba8b
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR builds console static assets into the server docker image at
/srv/console-assets. When env varHASURA_GRAPHQL_CONSOLE_ASSETS_DIR=/srv/console-assetsor flag--console-assets-dir=/srv/console-assetsis set on the server, the files in this directory are served at/console/assets/*.The console html template will have a variable called
cdnAssets: falsewhen this flag is set and it loads assets from server itself instead of CDN.The assets are moved to a new bucket with a new naming scheme:
Console served by CLI will still load assets from CDN - will fix that in the next release.