fix sending duplicate content-type header to remote schemas (fix #2159) #2170
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- the wreqOptions helper function would add a content-type header to every request. Fixed that to check if it exists and only add when its missing.
|
Deploy preview for hasura-docs ready! Built with commit f17debe |
Contributor
|
Review app for commit 2781bc7 deployed to Heroku: https://hge-ci-pull-2170.herokuapp.com |
0x777
approved these changes
May 13, 2019
Contributor
|
Review app for commit f17debe deployed to Heroku: https://hge-ci-pull-2170.herokuapp.com |
Contributor
|
Review app https://hge-ci-pull-2170.herokuapp.com is deleted |
polRk
pushed a commit
to polRk/graphql-engine
that referenced
this pull request
Feb 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In remote schema when "forward all headers from client" option was checked, and the client sent a
content-typeheader, there were twocontent-typeheaders that were being sent. Fixed that.Affected components
Related Issues
#2159
Solution and Design
Ignore any
content-typeheader sent by the client.Steps to test and verify
content-typeheader setcontent-typeheader isapplication/jsonand no duplicate headers are sent.Limitations, known bugs & workarounds