close websocket connection on JWT expiry (fix #578) #2156
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolve Conflicts: server/src-lib/Hasura/GraphQL/Transport/WebSocket.hs
|
Deploy preview for hasura-docs ready! Built with commit 41506f9 |
Contributor
|
Review app for commit be0b3e9 deployed to Heroku: https://hge-ci-pull-2156.herokuapp.com |
Explicitly return jwt expiry time while resolving user info
Contributor
|
Review app for commit 936dff3 deployed to Heroku: https://hge-ci-pull-2156.herokuapp.com |
0x777
reviewed
May 13, 2019
0x777
reviewed
May 13, 2019
Contributor
|
Review app for commit 3667311 deployed to Heroku: https://hge-ci-pull-2156.herokuapp.com |
Contributor
|
Review app for commit 41506f9 deployed to Heroku: https://hge-ci-pull-2156.herokuapp.com |
0x777
approved these changes
May 14, 2019
Contributor
|
Review app https://hge-ci-pull-2156.herokuapp.com is deleted |
polRk
pushed a commit
to polRk/graphql-engine
that referenced
this pull request
Feb 12, 2020
hasura-bot
pushed a commit
that referenced
this pull request
Sep 3, 2025
Add `forward_headers` config to `pre-ndc-request-plugin` which allows request headers to be forwarded to `pre-ndc-request` plugins. V3_GIT_ORIGIN_REV_ID: 37035e9ff39716b6fead05275e0dc9633f351198
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Close WebSocket connection while subscriptions on JWT expiry.
Affected components
Related Issues
close #578
Solution and Design
Run an async thread on websocket connection accept which terminates on JWT expiry.
Steps to test and verify
Perform a subscription query with JWT setup. The server should close connection on JWT expiry.
Limitations, known bugs & workarounds