这是indexloc提供的服务，不要输入任何密码
Skip to content

add schema create/delete options in console (closes #2142) #2143

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
May 15, 2019
Merged

add schema create/delete options in console (closes #2142) #2143

merged 9 commits into from
May 15, 2019

Conversation

@rikinsk-zz
Copy link

@rikinsk-zz rikinsk-zz commented May 8, 2019 •
edited
Loading

Description

Affected components

  • Console

Related Issues

#2142

Solution and Design

Steps to test and verify

Limitations, known bugs & workarounds

@rikinsk-zz rikinsk-zz added s/wip Status: This issue is a work in progress c/console Related to console labels May 8, 2019
@netlify
Copy link

netlify bot commented May 8, 2019 •
edited
Loading

Deploy preview for hasura-docs ready!

Built with commit 3a6b365

https://deploy-preview-2143--hasura-docs.netlify.com

@hasura-bot
Copy link
Contributor

hasura-bot commented May 8, 2019

Review app for commit 1d96e30 deployed to Heroku: https://hge-ci-pull-2143.herokuapp.com
Docker image for server: hasura/graphql-engine:pull2143-1d96e30b

@mnlbox
Copy link
Contributor

mnlbox commented May 8, 2019

@rikinsk Any screenshot?

@rikinsk-zz
Copy link
Author

rikinsk-zz commented May 8, 2019

@mnlbox Its still a WIP. The functionality needs to be wired up. You can see the suggested UI at https://hge-ci-pull-2143.herokuapp.com/console/data/schema/public

@mnlbox
Copy link
Contributor

mnlbox commented May 8, 2019

@rikinsk It seems it's not working 🤔
schema

@mnlbox
Copy link
Contributor

mnlbox commented May 8, 2019

Why we still need two schema selector?
Screenshot from 2019-05-08 16-31-47
I think main schema selector bellow the Hasura logo is enough. Also we can add create and delete button on that panel like this:
Screenshot from 2019-05-08 16-31-47 (copy)

@dsandip dsandip changed the title add schema create/delete options in console add schema create/delete options in console (closes #2142) May 13, 2019
@hasura-bot
Copy link
Contributor

hasura-bot commented May 14, 2019

Review app for commit 2fdea20 deployed to Heroku: https://hge-ci-pull-2143.herokuapp.com
Docker image for server: hasura/graphql-engine:pull2143-2fdea20a

@mnlbox
Copy link
Contributor

mnlbox commented May 15, 2019 •
edited
Loading

Also related: #337

wawhal
wawhal approved these changes May 15, 2019
View reviewed changes
Copy link
Contributor

@wawhal wawhal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rikinsk-zz rikinsk-zz merged commit d6995c3 into hasura:master May 15, 2019
@hasura-bot
Copy link
Contributor

hasura-bot commented May 15, 2019

Review app https://hge-ci-pull-2143.herokuapp.com is deleted

@rikinsk-zz rikinsk-zz deleted the console-schema branch May 15, 2019 14:00
@hasura-bot
Copy link
Contributor

hasura-bot commented May 15, 2019

Review app for commit 3a6b365 deployed to Heroku: https://hge-ci-pull-2143.herokuapp.com
Docker image for server: hasura/graphql-engine:pull2143-3a6b3653

polRk pushed a commit to polRk/graphql-engine that referenced this pull request Feb 12, 2020
@rikinsk @polRk
add schema create/delete options in console (closes hasura#2142) (has…
c1d4f83 
…ura#2143)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@wawhal wawhal wawhal approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

c/console Related to console s/wip Status: This issue is a work in progress

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@rikinsk-zz @hasura-bot @mnlbox @wawhal @rikinsk