learn: add react native tutorial #2136
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for hasura-docs ready! Built with commit d93ca89 |
72feb0f to
b0f95f1
Compare
…hasura-react-native
…-engine into learn-hasura-react-native
vnovick
suggested changes
May 13, 2019
Contributor
vnovick
left a comment
There was a problem hiding this comment.
Please change inconsistencies in the docs and between sections
And most importantly please create a new engine instance for react-native and mobile in general with the same custom auth you are using because we need to run graphiql on that engine.
|
|
||
| ```graphql | ||
| - query { | ||
| + query ($is_public: Boolean) { |
Contributor
There was a problem hiding this comment.
later on you use $isPublic - please change to that
| + created_at: desc | ||
| + }, | ||
| - where: { is_public: { _eq: false} } | ||
| + where: { is_public: { _eq: $is_public} } |
| id | ||
| title | ||
| created_at | ||
| is_completed |
Contributor
There was a problem hiding this comment.
add here user and basically all data you get in the next section.
shahidhk
approved these changes
May 13, 2019
Contributor
|
Review app https://hge-ci-pull-2136.herokuapp.com is deleted |
polRk
pushed a commit
to polRk/graphql-engine
that referenced
this pull request
Feb 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add React Native tutorial
Description
Affected components
Related Issues
Solution and Design
Steps to test and verify
Limitations, known bugs & workarounds