fix duplicate headers being sent to remote schema #2118
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
following is the order of precedence of headers now: conf headers > resolved userinfo vars > client headers
|
Deploy preview for hasura-docs ready! Built with commit 25a118e |
Contributor
|
Review app for commit 51fc1bf deployed to Heroku: https://hge-ci-pull-2118.herokuapp.com |
Contributor
|
Review app for commit de84ff0 deployed to Heroku: https://hge-ci-pull-2118.herokuapp.com |
de84ff0 to
9a1a4e1
Compare
Contributor
|
Review app for commit c9c73fe deployed to Heroku: https://hge-ci-pull-2118.herokuapp.com |
0x777
previously approved these changes
May 6, 2019
0x777
previously approved these changes
May 6, 2019
Contributor
|
Review app for commit 25a118e deployed to Heroku: https://hge-ci-pull-2118.herokuapp.com |
0x777
approved these changes
May 6, 2019
Contributor
|
Review app https://hge-ci-pull-2118.herokuapp.com is deleted |
polRk
pushed a commit
to polRk/graphql-engine
that referenced
this pull request
Feb 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In some cases,
x-hasura-*headers and configured headers were sent with multiple values to remote schema.Following is the order of precedence of headers now:
conf headers > resolved userinfo vars > client headers
Affected components
Related Issues
Solution and Design
Remove duplicates by merging them in a map. The order of precedence is:
conf headers > resolved userinfo vars > client headers
Steps to test and verify
Limitations, known bugs & workarounds