这是indexloc提供的服务,不要输入任何密码
Skip to content

Conversation

@rakeshkky
Copy link
Member

Description

If a user tries to update column nullability or it's type via modify table or SQL section of the console then update the cache with new column info.

[via @anisjonischkeit]

Affected components

  • Server
  • Tests

Related Issues

fix #2101

Solution and Design

Update PGColInfo of a column on any of pgiType and pgiIsNullable change via run_sql /v1/query metadata query.

Steps to test and verify

Create a table and modify any column's nullability or type. This change should reflect in GraphQL schema.

@rakeshkky rakeshkky added s/ok-to-merge Status: This pull request can be merged to master c/server Related to server labels May 2, 2019
@rakeshkky rakeshkky requested a review from 0x777 as a code owner May 2, 2019 10:08
@rakeshkky rakeshkky self-assigned this May 2, 2019
@rakeshkky rakeshkky added the e/quickfix can be wrapped up in few hours label May 2, 2019
@rakeshkky rakeshkky changed the title update schema cache on columns' null-ability and type changes (fix #2101) update schema cache on columns' null-ability or type changes (fix #2101) May 2, 2019
@netlify
Copy link

netlify bot commented May 2, 2019

Deploy preview for hasura-docs ready!

Built with commit 471716c

https://deploy-preview-2106--hasura-docs.netlify.com

@hasura-bot
Copy link
Contributor

Review app for commit 471716c deployed to Heroku: https://hge-ci-pull-2106.herokuapp.com
Docker image for server: hasura/graphql-engine:pull2106-471716c

@0x777 0x777 merged commit b436948 into hasura:master May 2, 2019
@hasura-bot
Copy link
Contributor

Review app https://hge-ci-pull-2106.herokuapp.com is deleted

@shahidhk shahidhk added the k/bug Something isn't working label May 6, 2019
polRk pushed a commit to polRk/graphql-engine that referenced this pull request Feb 12, 2020
hasura-bot pushed a commit that referenced this pull request Aug 7, 2025
<!-- The PR description should answer 2 important questions: -->

### What

Implement rules-based input types in OpenDD. Behind a feature flag and
not currently exposed via JSONSchema.

V3_GIT_ORIGIN_REV_ID: de41df50baefecef1b6bd9dadca66f84208d3a91
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c/server Related to server e/quickfix can be wrapped up in few hours k/bug Something isn't working s/ok-to-merge Status: This pull request can be merged to master

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Changing a field from nullable to not nullable doesn't update the graphql schema

4 participants