这是indexloc提供的服务,不要输入任何密码
Skip to content

Conversation

@rikinsk-zz
Copy link

@rikinsk-zz rikinsk-zz commented May 6, 2019

Description

Sanitize generated migration filenames in console before hitting API

Affected components

  • Console
  • Community

Related Issues

#2094

Solution and Design

Use sanitize-filename library in console

Steps to test and verify

Limitations, known bugs & workarounds

@netlify
Copy link

netlify bot commented May 6, 2019

Deploy preview for hasura-docs ready!

Built with commit 0987e03

https://deploy-preview-2123--hasura-docs.netlify.com

@rikinsk-zz rikinsk-zz requested a review from shahidhk as a code owner May 6, 2019 09:07
@hasura-bot
Copy link
Contributor

Review app for commit 9b6bf6f deployed to Heroku: https://hge-ci-pull-2123.herokuapp.com
Docker image for server: hasura/graphql-engine:pull2123-9b6bf6f2

@hasura-bot
Copy link
Contributor

Review app for commit d8c454d deployed to Heroku: https://hge-ci-pull-2123.herokuapp.com
Docker image for server: hasura/graphql-engine:pull2123-d8c454de

Copy link
Member

@shahidhk shahidhk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hasura-bot
Copy link
Contributor

Review app for commit 0987e03 deployed to Heroku: https://hge-ci-pull-2123.herokuapp.com
Docker image for server: hasura/graphql-engine:pull2123-0987e03c

@shahidhk shahidhk merged commit 5b9e99a into hasura:master May 7, 2019
@hasura-bot
Copy link
Contributor

Review app https://hge-ci-pull-2123.herokuapp.com is deleted

@rikinsk-zz rikinsk-zz deleted the migration-filename branch May 7, 2019 07:37
polRk pushed a commit to polRk/graphql-engine that referenced this pull request Feb 12, 2020
hasura-bot pushed a commit that referenced this pull request Aug 14, 2025
V3_GIT_ORIGIN_REV_ID: f7fe2e47b0b974725359268f63ae9bf2577431ca
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants