这是indexloc提供的服务，不要输入任何密码
Skip to content

check for updates every 24 hrs in background (fix #204) #209

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jul 27, 2018
Merged

check for updates every 24 hrs in background (fix #204) #209

merged 5 commits into from
Jul 27, 2018

Conversation

@ecthiender
Copy link
Contributor

@ecthiender ecthiender commented Jul 25, 2018

No description provided.

@ecthiender ecthiender added the c/server Related to server label Jul 25, 2018
@ecthiender ecthiender requested a review from 0x777 July 25, 2018 14:05
0x777
0x777 reviewed Jul 26, 2018
View reviewed changes
server/src-lib/Hasura/Server/CheckUpdates.hs Outdated

$(A.deriveJSON (A.aesonDrop 2 A.snakeCase) ''UpdateInfo)

checkForUpdates :: IO ()
Copy link
Member

@0x777 0x777 Jul 26, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do not create another loggerset. We can use the one created in main

@ecthiender
Copy link
Contributor Author

ecthiender commented Jul 26, 2018

I'm exporting the LoggerCtx data constructor, to retrieve the logger set. Is that fine?

Ideally, should we have a different instance for logs which are not JSON? UserMessageLog or something, and mkLogger is parameterized (should work on EngineLog and UserMessageLog) ?

@shahidhk
Copy link
Member

shahidhk commented Jul 27, 2018

@0x777 @ecthiender Is this okay to merge?

@ecthiender
Copy link
Contributor Author

ecthiender commented Jul 27, 2018

@0x777 has to review

@0x777
Copy link
Member

0x777 commented Jul 27, 2018

LGTM

@shahidhk shahidhk merged commit 62b7b80 into hasura:master Jul 27, 2018
hgiasac pushed a commit to hgiasac/graphql-engine that referenced this pull request Dec 19, 2023
@rakeshkky @hgiasac
avoid ambiguous export of http::TraceableHttpResponse (hasura#209)
7105e16 
GitOrigin-RevId: f1bc15bc790d3788e9c96c1a49ccead5f51ed569
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@shahidhk shahidhk shahidhk approved these changes

@0x777 0x777 0x777 approved these changes

Assignees

No one assigned

Labels

c/server Related to server

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ecthiender @shahidhk @0x777