fix validation of null values, closes #1981 #2057
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for hasura-docs ready! Built with commit 979ac39 |
rakeshkky
approved these changes
Apr 24, 2019
Contributor
|
Review app for commit 979ac39 deployed to Heroku: https://hge-ci-pull-2057.herokuapp.com |
Contributor
|
Review app https://hge-ci-pull-2057.herokuapp.com is deleted |
polRk
pushed a commit
to polRk/graphql-engine
that referenced
this pull request
Feb 12, 2020
hasura-bot
pushed a commit
that referenced
this pull request
Jul 21, 2025
SQL layer doesn't check this is allowed before creating the OpenDD IR, so we need to add checking. Need to add a test for this before merging. V3_GIT_ORIGIN_REV_ID: 7d3c93659926e73634e3645e59a3706fa24b5ad4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The null value validation isn't handled correctly on the server. This PR fixes it. Closes #1981
Affected components
Related Issues
#1981
Steps to test and verify
Take a look at the newly added tests to reproduce this.