-
Notifications
You must be signed in to change notification settings - Fork 2.8k
do not account permission limit to aggregate queries (fix #1837) #2027
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Deploy preview for hasura-docs ready! Built with commit ce5aca8 |
|
Review app for commit e999322 deployed to Heroku: https://hge-ci-pull-2027.herokuapp.com |
|
Review app for commit f363d10 deployed to Heroku: https://hge-ci-pull-2027.herokuapp.com |
|
Review app for commit 422a41f deployed to Heroku: https://hge-ci-pull-2027.herokuapp.com |
|
@rakeshkky The order by expression used in SELECT
"_10_unnest_table"."nodes" AS "nodes",
"_10_unnest_table"."ob_col_1" AS "ob_col_1",
"_10_unnest_table"."ob_col_2" AS "ob_col_2"
FROM
UNNEST(
array_agg("nodes"),
array_agg("root.pg.album_id"),
array_agg("root.ar.aggregate.order_by.count")
) AS "_10_unnest_table"("nodes", "ob_col_1", "ob_col_2")
ORDER BY
"ob_col_1" ASC NULLS LAST,
"ob_col_2" DESC NULLS FIRST
LIMIT
10 -- permission limit |
|
Review app for commit fec521f deployed to Heroku: https://hge-ci-pull-2027.herokuapp.com |
|
Review app for commit 104a437 deployed to Heroku: https://hge-ci-pull-2027.herokuapp.com |
|
Review app for commit ce5aca8 deployed to Heroku: https://hge-ci-pull-2027.herokuapp.com |
|
Review app https://hge-ci-pull-2027.herokuapp.com is deleted |
<!-- The PR description should answer 2 important questions: --> ### What Update changelog. V3_GIT_ORIGIN_REV_ID: 1b23a835ef4015310d280ba3473233be3f23a930
Description
Don't consider permission limit for querying aggregate fields. Only apply permission limit for selection fields.
Affected components
Related Issues
fix #1837
Solution and Design
Apply permission limit only for
nodesfield of aggregate queries. Generated SQL usesUNNESTfeature of Postgres to selectnodeswith permission limit.SQL:-
Steps to test and verify