这是indexloc提供的服务,不要输入任何密码
Skip to content

Conversation

@ecthiender
Copy link
Contributor

@shahidhk I have split the workflow into 2 workflows. One for PRs and pushes to any branch except dev and release. (build_and_test). And second for releases, for pushes to release and dev branches. Please review/verify this.

@rakeshkky @0x777 mutiple tests fail on Postgres 9.4. These are the failing tests:

  1. GraphQL API Upserts article data via GraphQL mutation
    status mismatch:
    expected: 200
    but got: 500

  2. GraphQL API Upserts article data via GraphQL mutation
    status mismatch:
    expected: 200
    but got: 500

  3. GraphQL API Upserts article data via GraphQL mutation
    status mismatch:
    expected: 200
    but got: 500

  4. GraphQL API Updated person data using _append operator
    status mismatch:
    expected: 200
    but got: 500

  5. GraphQL API Updated person data using _prepend operator
    status mismatch:
    expected: 200
    but got: 500

  6. GraphQL API Updated person data using _delete_key operator
    status mismatch:
    expected: 200
    but got: 500

  7. GraphQL API Updated person data using _delete_elem operator
    status mismatch:
    expected: 200
    but got: 500

  8. GraphQL API Updated person data using _delete_at_path operator
    status mismatch:
    expected: 200
    but got: 500

@ecthiender ecthiender requested a review from shahidhk July 24, 2018 07:32
@0x777
Copy link
Member

0x777 commented Jul 24, 2018

upsert and json functions which back the _append, _prepend etc. are only part of postgres 9.5

@ecthiender
Copy link
Contributor Author

So are we supporting 9.4 then? @0x777

- move back to one workflow, and conditional build in the server build stage
@ecthiender ecthiender changed the title server tests now run across supported postgres versions >= 9.4 (fix #154) server tests now run across supported postgres versions >= 9.5 (fix #154) Jul 25, 2018
@ecthiender
Copy link
Contributor Author

Not testing 9.4 right now.

Apart from upsert and few JSON operators graphql-engine works on postgres 9.4. (See #210)

@shahidhk shahidhk merged commit c747971 into hasura:master Jul 26, 2018
hasura-bot pushed a commit that referenced this pull request Jan 30, 2024
V3_GIT_ORIGIN_REV_ID: e1f756a53bbbce722032df4f9b44f33473a09a1f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants