这是indexloc提供的服务，不要输入任何密码
Skip to content

add all PG column types while table creation / modification #1933

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 42 commits into from
May 22, 2019
Merged

add all PG column types while table creation / modification #1933

merged 42 commits into from
May 22, 2019

Conversation

@karthikvt26
Copy link
Contributor

@karthikvt26 karthikvt26 commented Apr 2, 2019 •
edited by rikinsk-zz
Loading

Fix #223, #2035, #394, #2038

Description

Affected components

  • Console

Related Issues

Solution and Design

Steps to test and verify

Limitations, known bugs & workarounds

@netlify
Copy link

netlify bot commented Apr 2, 2019 •
edited
Loading

Deploy preview for hasura-docs ready!

Built with commit 4ddb6ca

https://deploy-preview-1933--hasura-docs.netlify.com

@rikinsk-zz rikinsk-zz added the c/console Related to console label Apr 3, 2019
@dsandip dsandip added this to the release-candidates milestone Apr 15, 2019
@hasura-bot
Copy link
Contributor

hasura-bot commented Apr 19, 2019

Review app for commit 89e38e9 deployed to Heroku: https://hge-ci-pull-1933.herokuapp.com
Docker image for server: hasura/graphql-engine:pull1933-89e38e9

@rikinsk-zz rikinsk-zz changed the title Add searchable input box for column type input add all PG column types while table creation / modification Apr 22, 2019
@rikinsk-zz rikinsk-zz mentioned this pull request Apr 22, 2019
Closed
@rikinsk-zz rikinsk-zz mentioned this pull request Apr 24, 2019
Closed
@RodolfoSilva
Copy link
Contributor

RodolfoSilva commented Apr 24, 2019

I think this will solve this issue too #2038

@rikinsk-zz rikinsk-zz self-requested a review as a code owner May 15, 2019 12:31
@hasura-bot
Copy link
Contributor

hasura-bot commented May 17, 2019

Review app for commit c6e99d9 deployed to Heroku: https://hge-ci-pull-1933.herokuapp.com
Docker image for server: hasura/graphql-engine:pull1933-c6e99d90

RodolfoSilva
RodolfoSilva previously approved these changes May 21, 2019
View reviewed changes
@hasura-bot
Copy link
Contributor

hasura-bot commented May 21, 2019

Review app for commit 2c288cc deployed to Heroku: https://hge-ci-pull-1933.herokuapp.com
Docker image for server: hasura/graphql-engine:pull1933-2c288ccb

@hasura-bot
Copy link
Contributor

hasura-bot commented May 22, 2019

Review app for commit 6f037ac deployed to Heroku: https://hge-ci-pull-1933.herokuapp.com
Docker image for server: hasura/graphql-engine:pull1933-6f037ac0

@hasura-bot
Copy link
Contributor

hasura-bot commented May 22, 2019

Review app for commit 4ddb6ca deployed to Heroku: https://hge-ci-pull-1933.herokuapp.com
Docker image for server: hasura/graphql-engine:pull1933-4ddb6cac

@rikinsk-zz rikinsk-zz merged commit 8a9901d into hasura:master May 22, 2019
@hasura-bot
Copy link
Contributor

hasura-bot commented May 22, 2019

Review app https://hge-ci-pull-1933.herokuapp.com is deleted

@rikinsk-zz rikinsk-zz mentioned this pull request May 22, 2019
Closed
polRk pushed a commit to polRk/graphql-engine that referenced this pull request Feb 12, 2020
@karthikvt26 @polRk
add all PG column types in table add / modify (close hasura#223, hasu…
f706b96 
…ra#2035, hasura#394, hasura#2038) (hasura#1933)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@rikinsk-zz rikinsk-zz rikinsk-zz approved these changes

@RodolfoSilva RodolfoSilva RodolfoSilva left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

c/console Related to console s/do-not-merge Do not merge this pull request to master

Projects

None yet

Milestone

release-candidates

Development

Successfully merging this pull request may close these issues.

Add all postgres types support (e.g. lat/long) in create/modify table

6 participants

@karthikvt26 @hasura-bot @RodolfoSilva @rikinsk-zz @dsandip @rikinsk