update remote schema env var validation components #1932
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for hasura-docs ready! Built with commit 6667f1e |
Author
|
@tirumaraiselvan we need to update the error message returned by server in case of missing env var. It uses the phrase "custom resolver" which users dont know. Lets make int consistent with message for event triggers. The message there is generic enough. Similarly for any other error message we throw. remote schema instead of custom resolver needs to happen. |
Contributor
tirumaraiselvan
approved these changes
Apr 2, 2019
Contributor
|
Review app for commit 6667f1e deployed to Heroku: https://hge-ci-pull-1932.herokuapp.com |
Contributor
|
Review app https://hge-ci-pull-1932.herokuapp.com is deleted |
hasura-bot
pushed a commit
that referenced
this pull request
Jun 4, 2025
so we don't get paged <!-- The PR description should answer 2 important questions: --> ### What <!-- What is this PR trying to accomplish (and why, if it's not obvious)? --> <!-- Consider: do we need to add a changelog entry? --> <!-- Does this PR introduce new validation that might break old builds? --> <!-- Consider: do we need to put new checks behind a flag? --> ### How <!-- How is it trying to accomplish it (what are the implementation steps)? --> V3_GIT_ORIGIN_REV_ID: 6cbc5b54d214b649633dc16482a54dfd85dff5dd
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Affected components
Related Issues
Solution and Design
Steps to test and verify
Limitations, known bugs & workarounds