added feedback for metadata commands (close #1411) #1929
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for hasura-docs ready! Built with commit c0ad18c |
Contributor
|
Review app for commit 8b382bb deployed to Heroku: https://hge-ci-pull-1929.herokuapp.com |
shahidhk
approved these changes
Apr 3, 2019
Contributor
|
Review app https://hge-ci-pull-1929.herokuapp.com is deleted |
Contributor
|
Review app for commit c0ad18c deployed to Heroku: https://hge-ci-pull-1929.herokuapp.com |
polRk
pushed a commit
to polRk/graphql-engine
that referenced
this pull request
Feb 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
the metadata commands should give feedback like Applying metadata..., Metadata applied.
Affected components
Related Issues
#1411
Solution and Design
Used logrus.Logger to issue feedback message
Steps to test and verify
Run
hasura metadata apply