rename metadata reset to metadta clear (close #1851) #1893
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for hasura-docs ready! Built with commit b73a5af |
Contributor
|
Review app for commit 25ca350 deployed to Heroku: https://hge-ci-pull-1893.herokuapp.com |
shahidhk
requested changes
Mar 28, 2019
Contributor
|
Review app for commit 4be117f deployed to Heroku: https://hge-ci-pull-1893.herokuapp.com |
Contributor
|
Review app for commit b73a5af deployed to Heroku: https://hge-ci-pull-1893.herokuapp.com |
shahidhk
approved these changes
Mar 29, 2019
Contributor
|
Review app https://hge-ci-pull-1893.herokuapp.com is deleted |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The word "reset" is little ambiguous (reset to scratch or reset to last known consistent state). metadata reset clears the all the metadata to mimic a freshly installed hasura instance. This actually invokes the clear_metadata API in the backend and hence should also be called metadata clear for perfect clarity.
All references to metadata reset should be changed to metadata clear.
Affected components
Related Issues
#1851
Solution and Design
Changed main command name from reset to clear and added an alias reset.