Manual event triggers: invoke event triggers manually on rows (close #1687) #1872

tirumaraiselvan · 2019-03-26T11:36:32Z

Description

The new API adds an optional manual BOOLEAN key to the spec:

{
    "type" : "create_event_trigger",
    "args" : {
        "name": "testtrigger",
        "table": "users",
        "webhook": "https://httpbin.org/post",
        "insert": {
            "columns": "*"
        },
        "manual": true
    }
}

Affected components

Server
Console
Docs

Related Issues

#1687

Solution and Design

Create a new v1 query type: invoke_event_trigger
Create a function which takes row data and related metadata and inserts into event_log.
Use above function to take params from invoke_event_trigger

Steps to test and verify

Create a table:

curl 'http://localhost:8080/v1/query'  -H 'Content-Type: application/json'  -d '{"type":"bulk","args":[{"type":"run_sql","args":{"sql":"CREATE TABLE public.\"users\"(\"username\" text NOT NULL, \"real_name\" text NOT NULL, PRIMARY KEY (\"username\") );"}},{"type":"add_existing_table_or_view","args":{"name":"users","schema":"public"}}]}'

Create an event trigger with manual spec:

curl -H 'Content-Type: application/json' -X POST -d '{"type": "create_event_trigger", "args": {"name": "testtrigger", "table": "users", "update": { "columns" : ["username", "real_name"]},"insert": { "columns" : ["username"] }, "manual": true, "webhook": "https://httpbin.org/post" } }' localhost:8080/v1/query

Invoke an event manually:

curl -d '{"type": "invoke_event_trigger", "args": {"name": "testtrigger", "new": { "username": "manualusername", "real_name": "manualrealname"}, "old": null}}' localhost:8080/v1/query

Limitations, known bugs & workarounds

netlify · 2019-03-26T11:37:34Z

Deploy preview for hasura-docs ready!

Built with commit 03b9d27

https://deploy-preview-1872--hasura-docs.netlify.com

hasura-bot · 2019-03-26T13:05:45Z

Review app for commit 233bbdf deployed to Heroku: https://hge-ci-pull-1872.herokuapp.com
Docker image for server: hasura/graphql-engine:pull1872-233bbdf

hasura-bot · 2019-03-26T14:18:19Z

Review app for commit 6c533fc deployed to Heroku: https://hge-ci-pull-1872.herokuapp.com
Docker image for server: hasura/graphql-engine:pull1872-6c533fc

hasura-bot · 2019-04-09T08:26:52Z

Review app for commit 973972d deployed to Heroku: https://hge-ci-pull-1872.herokuapp.com
Docker image for server: hasura/graphql-engine:pull1872-973972d

hasura-bot · 2019-04-09T10:31:30Z

Review app for commit 041bde4 deployed to Heroku: https://hge-ci-pull-1872.herokuapp.com
Docker image for server: hasura/graphql-engine:pull1872-041bde4

…aphql-engine into manual-event-triggers

…-event-triggers # Conflicts: # server/src-rsr/migrate_from_12_to_13.sql

…aphql-engine into manual-event-triggers

hasura-bot · 2019-04-10T06:37:13Z

Review app for commit 3517eca deployed to Heroku: https://hge-ci-pull-1872.herokuapp.com
Docker image for server: hasura/graphql-engine:pull1872-3517eca

hasura-bot · 2019-04-10T10:26:30Z

Review app for commit 251b3de deployed to Heroku: https://hge-ci-pull-1872.herokuapp.com
Docker image for server: hasura/graphql-engine:pull1872-251b3de

…aphql-engine into manual-event-triggers

…ual-event-triggers

hasura-bot · 2019-04-25T06:24:12Z

Review app for commit 8c981bd deployed to Heroku: https://hge-ci-pull-1872.herokuapp.com
Docker image for server: hasura/graphql-engine:pull1872-8c981bd5

trekze · 2019-04-25T07:03:32Z

Tested the feature on the review app with glitch. Seems to work correctly!

…tate post unmounting

hasura-bot · 2019-04-25T10:25:01Z

Review app for commit db02a93 deployed to Heroku: https://hge-ci-pull-1872.herokuapp.com
Docker image for server: hasura/graphql-engine:pull1872-db02a931

hasura-bot · 2019-04-25T13:39:52Z

Review app for commit 82f2267 deployed to Heroku: https://hge-ci-pull-1872.herokuapp.com
Docker image for server: hasura/graphql-engine:pull1872-82f2267b

hasura-bot · 2019-04-25T15:58:03Z

Review app for commit 3a3484c deployed to Heroku: https://hge-ci-pull-1872.herokuapp.com
Docker image for server: hasura/graphql-engine:pull1872-3a3484cf

hasura-bot · 2019-04-26T06:56:48Z

Review app for commit 03b9d27 deployed to Heroku: https://hge-ci-pull-1872.herokuapp.com
Docker image for server: hasura/graphql-engine:pull1872-03b9d279

tirumaraiselvan · 2019-04-26T09:09:20Z

Closing this draft PR for actual PR

hasura-bot · 2019-04-26T09:09:22Z

Review app https://hge-ci-pull-1872.herokuapp.com is deleted

tirumaraiselvan and others added 8 commits March 13, 2019 15:33

break trigger function into separate functions

033317f

add manual to trigger type

6de93fa

create InvokeEventTrigger query type

710d322

return id in response

4282b12

add manual (bool) to create_event_trigger query

43728ed

npm installed

e6a9400

Merge remote-tracking branch 'main/master'

2a31b3a

Merge remote-tracking branch 'main/master'

4ec7086

tirumaraiselvan changed the title ~~Manual event triggers: invoke event triggers manually on rows~~ Manual event triggers: invoke event triggers manually on rows (close #1687) Mar 26, 2019

tirumaraiselvan added 2 commits March 26, 2019 17:28

merge master

2c27821

fix catalog

233bbdf

tirumaraiselvan added 3 commits March 26, 2019 18:50

refactor validation

3ac6a3f

refactor trigger sql generation func

6d741c9

remove void

6c533fc

shahidhk added the c/server Related to server label Mar 27, 2019

karthikvt26 added 4 commits April 4, 2019 19:09

Merge remote-tracking branch 'main/master'

8642e67

Merge remote-tracking branch 'main/master'

8bbe6d9

Add data dropdown as per hasura#1687 design, WIP

058fae3

Merge branch 'issue-1687' into manual-event-triggers

973972d

manual event triggers overflow fix

041bde4

karthikvt26 and others added 5 commits April 9, 2019 16:48

WIP

4720d10

Merge branch 'manual-event-triggers' of github.com:tirumaraiselvan/gr…

facb963

…aphql-engine into manual-event-triggers

update trigger btn

e4b0430

Merge branch 'master' of github.com:hasura/graphql-engine into manual…

ea5c648

…-event-triggers # Conflicts: # server/src-rsr/migrate_from_12_to_13.sql

Merge branch 'manual-event-triggers' of github.com:tirumaraiselvan/gr…

5d90085

…aphql-engine into manual-event-triggers

karthikvt26 and others added 2 commits April 10, 2019 14:56

WIP

a1cf79e

overflow hidden fix for browse table

251b3de

Create event and wait for the event invocation status

d3c334e

dsandip added this to the release-candidates milestone Apr 15, 2019

karthikvt26 and others added 8 commits April 16, 2019 14:13

WIP

713d72c

Table row text overlays fixed and event and remote schema popup fixed

2b1905c

Merge branch 'manual-event-triggers' of github.com:tirumaraiselvan/gr…

84fcbe9

…aphql-engine into manual-event-triggers

Fix manual invocation modal, import connect

58aa328

add manual to configuration

aab6e8c

check manual conf before invoke

3024100

Fix conflicts and merge remote-tracking branch 'main/master' into man…

7dfffef

…ual-event-triggers

fix merge conflict

8c981bd

Support console option update -> Modify event trigger, reset modify s…

db02a93

…tate post unmounting

karthikvt26 requested review from rikinsk-zz and wawhal April 25, 2019 10:47

Modal ui fixes

82f2267

Redeliver event modal fix invocation log css

3a3484c

surendran82 and others added 2 commits April 26, 2019 11:46

Redeliver modal fix

ef6ef41

Fix redeliver event invocation name

03b9d27

tirumaraiselvan closed this Apr 26, 2019

Manual event triggers: invoke event triggers manually on rows (close #1687) #1872

Manual event triggers: invoke event triggers manually on rows (close #1687) #1872

Uh oh!

Conversation

tirumaraiselvan commented Mar 26, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Affected components

Related Issues

Solution and Design

Steps to test and verify

Limitations, known bugs & workarounds

Uh oh!

netlify bot commented Mar 26, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

hasura-bot commented Mar 26, 2019

Uh oh!

hasura-bot commented Mar 26, 2019

Uh oh!

hasura-bot commented Apr 9, 2019

Uh oh!

hasura-bot commented Apr 9, 2019

Uh oh!

hasura-bot commented Apr 10, 2019

Uh oh!

hasura-bot commented Apr 10, 2019

Uh oh!

hasura-bot commented Apr 25, 2019

Uh oh!

trekze commented Apr 25, 2019

Uh oh!

hasura-bot commented Apr 25, 2019

Uh oh!

hasura-bot commented Apr 25, 2019

Uh oh!

hasura-bot commented Apr 25, 2019

Uh oh!

hasura-bot commented Apr 26, 2019

Uh oh!

tirumaraiselvan commented Apr 26, 2019

Uh oh!

hasura-bot commented Apr 26, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

tirumaraiselvan commented Mar 26, 2019 •

edited

Loading

netlify bot commented Mar 26, 2019 •

edited

Loading