-
Notifications
You must be signed in to change notification settings - Fork 2.8k
allow to track all tables/relationships (close #1418) #1876
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Deploy preview for hasura-docs ready! Built with commit 0596a44 |
|
Review app for commit 56551e9 deployed to Heroku: https://hge-ci-pull-1876.herokuapp.com |
|
Review app for commit 2e68cb3 deployed to Heroku: https://hge-ci-pull-1876.herokuapp.com |
The issue is This issue is there on console too tracked in #1882
➜ ./hasura-dev metadata track --table table_1 --table table_2
|
|
@shahidhk What should we do in this case? Track only the relationships with the reference table name matches the --table flag? |
|
@karthikvt26 Is the relationships name generated is according to the console? |
|
@arvi3411301 Yes |
Also, while tracking all tables relations etc, the logs should clearly output what is tracked. |
|
Review app for commit 4027118 deployed to Heroku: https://hge-ci-pull-1876.herokuapp.com |
Will this also work for the track metadata API. Currently on SQL page if the checkbox is tracked and the table is already tracked the entire operation fails |
|
Review app for commit 81852c8 deployed to Heroku: https://hge-ci-pull-1876.herokuapp.com |
|
@karthikvt26 I had fixed column conflicts. Can you try again if this build fixes all issues? |
|
Review app for commit de663c8 deployed to Heroku: https://hge-ci-pull-1876.herokuapp.com |
|
Review app for commit 474ab73 deployed to Heroku: https://hge-ci-pull-1876.herokuapp.com |
|
@arvi3411301 Running with --table and --all-relationship option is not tracking the relationships |
|
@karthikvt26 In order to track relationships across tables, you need to specify --table table2. So, the command will be |
|
Ok the message is slightly confusing then ( |
|
@karthikvt26 We will be adding info/warn messages if something is missing. Something like, WARN: relationship referencing to table2 (cols) from table1 (cols) cannot be created since --table table2 is missing from command. But at the end, |
|
@arvi3411301 No no can we add logs as
|
|
Review app for commit 85265d3 deployed to Heroku: https://hge-ci-pull-1876.herokuapp.com |
|
Review app for commit 6fe34aa deployed to Heroku: https://hge-ci-pull-1876.herokuapp.com |
|
Review app for commit 0596a44 deployed to Heroku: https://hge-ci-pull-1876.herokuapp.com |
|
Review app https://hge-ci-pull-1876.herokuapp.com is deleted |
|
@arvi3411301 Why was this closed? |
|
@shahidhk need to rewrite everything. Will open a new PR. |
Description
CLI will be having the below command in order to track and untrack tables, relationships across schemas.
Affected components
Related Issues
#1418
Solution and Design
Steps to test and verify
Limitations, known bugs & workarounds
Table and relationships across schemas cannot be tracked