这是indexloc提供的服务,不要输入任何密码
Skip to content

Conversation

@simoneb
Copy link
Contributor

@simoneb simoneb commented Mar 21, 2019

Description

Fix completion directory name (missing leading dot) for bash on Windows

Affected components

  • Docs

@simoneb simoneb requested a review from rikinsk-zz as a code owner March 21, 2019 10:36
@hasura-bot
Copy link
Contributor

Beep boop! 🤖

Hey @simoneb, thanks for your PR!

One of my human friends will review this PR and get back to you as soon as possible. 🕐

Stay awesome! 😎

@CLAassistant
Copy link

CLAassistant commented Mar 21, 2019

CLA assistant check
All committers have signed the CLA.

@netlify
Copy link

netlify bot commented Mar 21, 2019

Deploy preview for hasura-docs ready!

Built with commit d10e3ba

https://deploy-preview-1832--hasura-docs.netlify.com

@shahidhk
Copy link
Member

Thanks for the PR @simoneb. The documentation is auto-generated from the CLI help. Can you also make the change here: https://github.com/hasura/graphql-engine/blob/master/cli/commands/completion.go#L29 ?

@shahidhk shahidhk added c/cli Related to CLI s/do-not-merge Do not merge this pull request to master labels Mar 27, 2019
@simoneb simoneb requested a review from shahidhk as a code owner March 27, 2019 23:55
@simoneb
Copy link
Contributor Author

simoneb commented Mar 27, 2019

@shahidhk done!

@hasura-bot
Copy link
Contributor

Review app for commit d10e3ba deployed to Heroku: https://hge-ci-pull-1832.herokuapp.com
Docker image for server: hasura/graphql-engine:pull1832-d10e3ba

@shahidhk shahidhk changed the title Fix completion directory name (missing leading dot) for bash on Windows fix bash completion example docs on cli Mar 28, 2019
Copy link
Member

@shahidhk shahidhk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shahidhk shahidhk merged commit f6c11e5 into hasura:master Mar 28, 2019
@hasura-bot
Copy link
Contributor

Review app https://hge-ci-pull-1832.herokuapp.com is deleted

@shahidhk shahidhk removed the s/do-not-merge Do not merge this pull request to master label Mar 28, 2019
@shahidhk
Copy link
Member

Thanks a ton @simoneb 👍

hasura-bot pushed a commit that referenced this pull request Apr 9, 2025
<!-- The PR description should answer 2 important questions: -->

### What

Got tripped up by this error when writing test metadata, because it says
there's no field in the object type, but it really means "there's no
field in the `BooleanExpressionType`", so fixed it.

V3_GIT_ORIGIN_REV_ID: 83c220451f914d816e3239835d5cc6dc07d44333
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c/cli Related to CLI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants