这是indexloc提供的服务,不要输入任何密码
Skip to content

Conversation

@ecthiender
Copy link
Contributor

Fix caching issues on build server job. Reduces server build time.

Description

Due to misconfiguration in the caching logic, server was building dependencies on every build. This fixes it to reduce server build time.

Affected components

  • Build System

Related Issues

Solution and Design

Steps to test and verify

Limitations, known bugs & workarounds

  fix caching issues on build server job. reduces server build time.
@ecthiender ecthiender added the c/build-system Related to the build-release system label Mar 21, 2019
@ecthiender ecthiender requested a review from nizar-m March 21, 2019 13:32
@netlify
Copy link

netlify bot commented Mar 21, 2019

Deploy preview for hasura-docs ready!

Built with commit ffddf39

https://deploy-preview-1836--hasura-docs.netlify.com

@hasura-bot
Copy link
Contributor

Review app for commit ffddf39 deployed to Heroku: https://hge-ci-pull-1836.herokuapp.com
Docker image for server: hasura/graphql-engine:pull1836-ffddf39

@shahidhk shahidhk merged commit cbd6bb1 into hasura:master Mar 22, 2019
@hasura-bot
Copy link
Contributor

Review app https://hge-ci-pull-1836.herokuapp.com is deleted

shahidhk added a commit that referenced this pull request Mar 25, 2019
hasura-bot pushed a commit that referenced this pull request Apr 17, 2025
<!-- The PR description should answer 2 important questions: -->

### What

When a `comparableRelationship` on a boolean expression type is defined,
but the target model did not have a `filterExpressionType` defined, we
acted as if the `comparableRelationship` was not defined, which is
really confusing.

This PR
a) adds a warning when such a thing that is set up, that turns into an
error when the compat flag is on
b) makes the `boolean_expression_type` in a resolved comparable
relationship optional, so we can tell the difference between "it's
defined but there's nothing there" and "it's not defined"

### How

<!-- How is it trying to accomplish it (what are the implementation
steps)? -->

V3_GIT_ORIGIN_REV_ID: 592385b9c942a39ff838130bb72d2e41790095d8
hasura-bot pushed a commit that referenced this pull request Apr 23, 2025
…ression_type` (#1867)

<!-- The PR description should answer 2 important questions: -->

### What

Since #1836 we've kept comparable relationships around, even if they
don't point to anything, so that later lookup errors can tell the
difference between "no relationship was defined" and "the relationship
points to nothing".

This means this model source checking is running where it wasn't before,
which is stopping a few builds generating.

### How

If a comparable relationship does not have a `booleanExpressionType` on
it, skip the checks.

V3_GIT_ORIGIN_REV_ID: 1da8258af0933b42b9d929a2961a4cc19d1bf7bb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c/build-system Related to the build-release system

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants