fix relationship editor bug where deleting one relationship expanded the next relationship #1814
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for hasura-docs ready! Built with commit f983b44 |
Contributor
|
Review app for commit 0581e1f deployed to Heroku: https://hge-ci-pull-1814.herokuapp.com |
Contributor
|
Review app for commit 7cf95a6 deployed to Heroku: https://hge-ci-pull-1814.herokuapp.com |
rikinsk-zz
approved these changes
Mar 19, 2019
Contributor
|
Review app https://hge-ci-pull-1814.herokuapp.com is deleted |
Contributor
|
Review app for commit f983b44 deployed to Heroku: https://hge-ci-pull-1814.herokuapp.com |
hasura-bot
pushed a commit
that referenced
this pull request
May 7, 2025
<!-- The PR description should answer 2 important questions: --> ### What This PR bumps up the datafusion to 47 ### How <!-- How is it trying to accomplish it (what are the implementation steps)? --> --------- Co-authored-by: Daniel Harvey <danieljamesharvey@gmail.com> V3_GIT_ORIGIN_REV_ID: 433160e496cd4bc690a0aa4ed11056f24977e2bd
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1813
Description
Affected components
Related Issues
#1813
Solution and Design
Earlier, the
keyprop each element in the iterator was just the index of the array. This caused the state of the previous element to be passed down to the subsequent element after its deletion.The issue is fixed by making the relationship name as the key of the elements in iterator.
Steps to test and verify
Add multiple object/array relationships. Their expanded/collapsed state should be totally independent.
Limitations, known bugs & workarounds