这是indexloc提供的服务，不要输入任何密码
Skip to content

add type, variable information to input value's ast (close #21) #1809

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 20, 2019
Merged

add type, variable information to input value's ast (close #21) #1809

merged 1 commit into from
Mar 20, 2019

Conversation

@0x777
Copy link
Member

@0x777 0x777 commented Mar 18, 2019

This information can be used for various optimisations (caching queries and subscriptions plans). Also fixes the long standing #21

Affected components

  • Server

@0x777
Copy link
Member Author

0x777 commented Mar 18, 2019

Depends on #1800

@netlify
Copy link

netlify bot commented Mar 18, 2019 •
edited
Loading

Deploy preview for hasura-docs ready!

Built with commit 42ec0ff

https://deploy-preview-1809--hasura-docs.netlify.com

@hasura-bot
Copy link
Contributor

hasura-bot commented Mar 18, 2019

Review app for commit 25969af deployed to Heroku: https://hge-ci-pull-1809.herokuapp.com
Docker image for server: hasura/graphql-engine:pull1809-25969af

@hasura-bot
Copy link
Contributor

hasura-bot commented Mar 18, 2019

Review app for commit 3983079 deployed to Heroku: https://hge-ci-pull-1809.herokuapp.com
Docker image for server: hasura/graphql-engine:pull1809-3983079

@hasura-bot
Copy link
Contributor

hasura-bot commented Mar 18, 2019

Review app for commit 987c051 deployed to Heroku: https://hge-ci-pull-1809.herokuapp.com
Docker image for server: hasura/graphql-engine:pull1809-987c051

rakeshkky
rakeshkky reviewed Mar 19, 2019
View reviewed changes
rakeshkky
rakeshkky previously approved these changes Mar 19, 2019
View reviewed changes
@CLAassistant
Copy link

CLAassistant commented Mar 19, 2019 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@hasura-bot
Copy link
Contributor

hasura-bot commented Mar 19, 2019

Review app for commit 42ec0ff deployed to Heroku: https://hge-ci-pull-1809.herokuapp.com
Docker image for server: hasura/graphql-engine:pull1809-42ec0ff

@shahidhk shahidhk added the c/server Related to server label Mar 20, 2019
@shahidhk
Copy link
Member

shahidhk commented Mar 20, 2019

@0x777 The last commit on master is a CLI change - hence no need to merge master into this branch for merging this.

@shahidhk shahidhk changed the title add type, variable information to input value's ast add type, variable information to input value's ast (close #21) Mar 20, 2019
@shahidhk shahidhk merged commit ac1749c into hasura:master Mar 20, 2019
@hasura-bot
Copy link
Contributor

hasura-bot commented Mar 20, 2019

Review app https://hge-ci-pull-1809.herokuapp.com is deleted

hasura-bot pushed a commit that referenced this pull request Apr 2, 2025
@paf31 @danieljharvey @hasura-bot
[PQL-232] COUNT DISTINCT for SQL pushdown (#1809)
76e5bfa 
<!-- The PR description should answer 2 important questions: -->

### What

<!-- What is this PR trying to accomplish (and why, if it's not
obvious)? -->

<!-- Consider: do we need to add a changelog entry? -->

<!-- Does this PR introduce new validation that might break old builds?
-->

<!-- Consider: do we need to put new checks behind a flag? -->

### How

<!-- How is it trying to accomplish it (what are the implementation
steps)? -->

---------

Co-authored-by: Daniel Harvey <danieljamesharvey@gmail.com>
V3_GIT_ORIGIN_REV_ID: 1625c883de99258178463c17b98dc02c564980dd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rakeshkky rakeshkky rakeshkky approved these changes

Assignees

No one assigned

Labels

c/server Related to server

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@0x777 @hasura-bot @CLAassistant @shahidhk @rakeshkky