Remove graphiql suggestion on page navigation #1803
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for hasura-docs ready! Built with commit 8390016 |
Contributor
|
Review app for commit fc1c19f deployed to Heroku: https://hge-ci-pull-1803.herokuapp.com |
rikinsk-zz
approved these changes
Mar 18, 2019
Contributor
|
Review app https://hge-ci-pull-1803.herokuapp.com is deleted |
Contributor
|
Review app for commit 8390016 deployed to Heroku: https://hge-ci-pull-1803.herokuapp.com |
hasura-bot
pushed a commit
that referenced
this pull request
Apr 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1530
Description
Removes the
hint dialogwhen the page is navigated fromapi explorerto any other pageAffected components
Related Issues
Fix #1530
Solution and Design
Remove the dom when the ApiExplorer component unmounts.
Steps to test and verify
CTRL + <SPACE>on the editor to get the hint and see if you don't get the hint box again.Limitations, known bugs & workarounds