这是indexloc提供的服务,不要输入任何密码
Skip to content

Conversation

@dsandip
Copy link
Member

@dsandip dsandip commented Mar 17, 2019

Description

Adds a multirole example loosely based on https://www.youtube.com/watch?v=kHCLQEKjdnI

Affected components

  • Docs

Solution and Design

The documented example covers a blog app use-case where users can take one or more of author, reviewer and editor roles.

@dsandip dsandip added k/enhancement New feature or improve an existing feature c/docs Related to docs p/urgent Immediate action required labels Mar 17, 2019
@dsandip dsandip requested a review from coco98 March 17, 2019 18:16
@dsandip dsandip requested a review from rikinsk-zz as a code owner March 17, 2019 18:16
@hasura-bot
Copy link
Contributor

Review app for commit ae34a85 deployed to Heroku: https://hge-ci-pull-1796.herokuapp.com
Docker image for server: hasura/graphql-engine:pull1796-ae34a85

@coco98
Copy link
Contributor

coco98 commented Mar 18, 2019

@shahidhk @arvi3411301 Can we get hasurabot to add a comment with a link to the docs? More convenient and noticeable than checking build logs to get the URL...

@coco98
Copy link
Contributor

coco98 commented Mar 18, 2019

@dsandip Can you link to the docs page where you've made the changes?

@dsandip
Copy link
Member Author

dsandip commented Mar 18, 2019

@netlify
Copy link

netlify bot commented Mar 18, 2019

Deploy preview for hasura-docs ready!

Built with commit faac6e6

https://deploy-preview-1796--hasura-docs.netlify.com

@shahidhk
Copy link
Member

@coco98 Configured netlify to comment with the URL.

@coco98
Copy link
Contributor

coco98 commented Mar 21, 2019

@dsandip The modelling for this example is not neat.
user_info table can just be user.
Why does the editor table not have a fk to the arcticle table?

@coco98
Copy link
Contributor

coco98 commented Mar 22, 2019

Suggestions:

/auth/common-roles-auth-examples.html page:

/auth/model-roles-in-db.html page:

  • How to model multiple roles in the database
    • non-hierarchial roles
    • info available in the same db or not
  • How to handle JWT / auth webhook (every user should have all roles)
    • JWT: allowed roles needs to be exhaustive and role needs to be a subset
    • webhook: resolve and send the right role
  • Current content on multiple roles, but have different columns for each role
    • schema needs to vary for select in the example
  • How to structure the UI and make API calls
    • role-based components

@dsandip dsandip self-assigned this Mar 29, 2019
@dsandip dsandip added s/do-not-merge Do not merge this pull request to master s/wip Status: This issue is a work in progress labels Mar 29, 2019
@dsandip dsandip removed the request for review from coco98 March 29, 2019 19:42
@dsandip
Copy link
Member Author

dsandip commented Mar 31, 2019

@coco98 I am incorporating suggestions from your last comment in phases, and with a slight difference:

@hasura-bot
Copy link
Contributor

Review app for commit 613a10e deployed to Heroku: https://hge-ci-pull-1796.herokuapp.com
Docker image for server: hasura/graphql-engine:pull1796-613a10e

@hasura-bot
Copy link
Contributor

Review app for commit b33967f deployed to Heroku: https://hge-ci-pull-1796.herokuapp.com
Docker image for server: hasura/graphql-engine:pull1796-b33967f9

@rikinsk-zz rikinsk-zz removed s/do-not-merge Do not merge this pull request to master s/wip Status: This issue is a work in progress labels May 17, 2019
@rikinsk-zz rikinsk-zz merged commit 6a5f17c into hasura:master May 17, 2019
@hasura-bot
Copy link
Contributor

Review app https://hge-ci-pull-1796.herokuapp.com is deleted

polRk pushed a commit to polRk/graphql-engine that referenced this pull request Feb 12, 2020
hasura-bot pushed a commit that referenced this pull request Apr 1, 2025
<!-- The PR description should answer 2 important questions: -->

### What

Following PRs such as hasura/v3-engine#1756,
return multiple object relationship errors where possible.

V3_GIT_ORIGIN_REV_ID: 98dd7b87116fa0485b72cff8e689d0b07d5ccfe5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c/docs Related to docs k/enhancement New feature or improve an existing feature p/urgent Immediate action required

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants