这是indexloc提供的服务,不要输入任何密码
Skip to content

Conversation

@dsandip
Copy link
Member

@dsandip dsandip commented Mar 12, 2019

Description

Affected components

  • Server
  • Console
  • CLI
  • Docs
  • Community Content
  • Build System
  • Tests
  • Other (list it)

Related Issues

Solution and Design

Steps to test and verify

Limitations, known bugs & workarounds

@hasura-bot
Copy link
Contributor

Review app for commit d9ea58b deployed to Heroku: https://hge-ci-pull-1744.herokuapp.com
Docker image for server: hasura/graphql-engine:pull1744-d9ea58b

@coco98
Copy link
Contributor

coco98 commented Mar 12, 2019

@dsandip I'm not sure if the docs are clear. It's also within the first docs section of simple queries, which makes it more confusing. As a new user looking for how to query stuff, this would be very surprising, it seems like this ought to be more "advanced postgres user" documentation?

Perhaps we should have a separate page for this, or maybe we should include it in the reference documentation? Maybe we should have a page for the different GraphQL types we generate.

Let's also update the JSON blogpost? https://blog.hasura.io/postgres-json-and-jsonb-type-support-on-graphql-41f586e47536/

@dsandip dsandip changed the title Testing review build for Grapql query json (hgiasac) add a json path argument to query values inside json columns - hgiasac (close #1598) Mar 15, 2019
@dsandip dsandip marked this pull request as ready for review March 15, 2019 13:18
@dsandip dsandip requested a review from shahidhk March 15, 2019 13:18
@hasura-bot
Copy link
Contributor

Review app for commit 4ce2c2a deployed to Heroku: https://hge-ci-pull-1744.herokuapp.com
Docker image for server: hasura/graphql-engine:pull1744-4ce2c2a

@shahidhk
Copy link
Member

@dsandip The commits in this PR are out of sync with master - i.e. some console changes are included. Need to figure out a way to fix that.

@shahidhk
Copy link
Member

Also, why is this a new PR? What happened to the old one?

@shahidhk
Copy link
Member

closing in favour of #1661

@shahidhk shahidhk closed this Mar 22, 2019
@hasura-bot
Copy link
Contributor

Review app https://hge-ci-pull-1744.herokuapp.com is deleted

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants