这是indexloc提供的服务，不要输入任何密码
Skip to content

add spatial predicates for geography columns (close #1674) #1735

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 35 commits into from
Mar 25, 2019
Merged

add spatial predicates for geography columns (close #1674) #1735

merged 35 commits into from
Mar 25, 2019

Conversation

@shahidhk
Copy link
Member

@shahidhk shahidhk commented Mar 12, 2019 •
edited
Loading

Description

This PR adds support for PostGIS spatial predicates on geography columns. The predicates are _st_d_within and _st_intersects.

Affected components

  • Server (adds required types)
  • Console (Permission builder needs update)
  • Tests
  • Docs

Related Issues

#1674

Solution and Design

The comparison expression input type generating function is extended to support geography the same way geometry is supported.

Steps to test and verify

Start hasura on Postgres with PostGIS enabled, create a table with geography and geometry columns:

create table test (
  id serial primary key,
  geometry_col geometry,
  geography_col geography
)

Using console GraphiQL Docs tab, verify that the geography_comparison_exp contains _st_d_within and _st_intersects.

Limitations, known bugs & workarounds

NA

@shahidhk shahidhk added the c/server Related to server label Mar 12, 2019
rakeshkky
rakeshkky reviewed Mar 12, 2019
View reviewed changes
@hasura-bot
Copy link
Contributor

hasura-bot commented Mar 12, 2019

Review app for commit ec3e275 deployed to Heroku: https://hge-ci-pull-1735.herokuapp.com
Docker image for server: hasura/graphql-engine:pull1735-ec3e275

@hasura-bot
Copy link
Contributor

hasura-bot commented Mar 12, 2019

Review app for commit d31d448 deployed to Heroku: https://hge-ci-pull-1735.herokuapp.com
Docker image for server: hasura/graphql-engine:pull1735-d31d448

@hasura-bot
Copy link
Contributor

hasura-bot commented Mar 12, 2019

Review app for commit a259e27 deployed to Heroku: https://hge-ci-pull-1735.herokuapp.com
Docker image for server: hasura/graphql-engine:pull1735-a259e27

@hasura-bot
Copy link
Contributor

hasura-bot commented Mar 12, 2019

Review app for commit ae133ab deployed to Heroku: https://hge-ci-pull-1735.herokuapp.com
Docker image for server: hasura/graphql-engine:pull1735-ae133ab

@shahidhk shahidhk changed the title add _st_* operators to geography comparison expression (close #1674) add sparial relationship operators for geography columns (close #1674) Mar 13, 2019
@shahidhk shahidhk changed the title add sparial relationship operators for geography columns (close #1674) add spatial relationship operators for geography columns (close #1674) Mar 13, 2019
@hasura-bot
Copy link
Contributor

hasura-bot commented Mar 13, 2019

Review app for commit f8280b2 deployed to Heroku: https://hge-ci-pull-1735.herokuapp.com
Docker image for server: hasura/graphql-engine:pull1735-f8280b2

@shahidhk shahidhk added c/console Related to console c/docs Related to docs labels Mar 14, 2019
@shahidhk shahidhk marked this pull request as ready for review March 14, 2019 10:53
@hasura-bot
Copy link
Contributor

hasura-bot commented Mar 14, 2019

Review app for commit 1533aef deployed to Heroku: https://hge-ci-pull-1735.herokuapp.com
Docker image for server: hasura/graphql-engine:pull1735-1533aef

@shahidhk shahidhk requested a review from rakeshkky March 15, 2019 05:27
@hasura-bot
Copy link
Contributor

hasura-bot commented Mar 19, 2019

Review app for commit d907b27 deployed to Heroku: https://hge-ci-pull-1735.herokuapp.com
Docker image for server: hasura/graphql-engine:pull1735-d907b27

@hasura-bot
Copy link
Contributor

hasura-bot commented Mar 20, 2019

Review app for commit 6f0e810 deployed to Heroku: https://hge-ci-pull-1735.herokuapp.com
Docker image for server: hasura/graphql-engine:pull1735-6f0e810

@hasura-bot
Copy link
Contributor

hasura-bot commented Mar 21, 2019

Review app for commit 2b6b8fd deployed to Heroku: https://hge-ci-pull-1735.herokuapp.com
Docker image for server: hasura/graphql-engine:pull1735-2b6b8fd

@hasura-bot
Copy link
Contributor

hasura-bot commented Mar 22, 2019

Review app for commit 76f4666 deployed to Heroku: https://hge-ci-pull-1735.herokuapp.com
Docker image for server: hasura/graphql-engine:pull1735-76f4666

ecthiender
ecthiender reviewed Mar 22, 2019
View reviewed changes
Copy link
Contributor

@ecthiender ecthiender left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hasura-bot
Copy link
Contributor

hasura-bot commented Mar 22, 2019

Review app for commit ce63293 deployed to Heroku: https://hge-ci-pull-1735.herokuapp.com
Docker image for server: hasura/graphql-engine:pull1735-ce63293

rikinsk-zz
rikinsk-zz previously approved these changes Mar 25, 2019
View reviewed changes
Copy link

@rikinsk-zz rikinsk-zz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

docs & console LGTM

@shahidhk shahidhk added the s/ok-to-merge Status: This pull request can be merged to master label Mar 25, 2019
@hasura-bot
Copy link
Contributor

hasura-bot commented Mar 25, 2019

Review app for commit 33ff74c deployed to Heroku: https://hge-ci-pull-1735.herokuapp.com
Docker image for server: hasura/graphql-engine:pull1735-33ff74c

@shahidhk shahidhk merged commit b8700cc into hasura:master Mar 25, 2019
@hasura-bot
Copy link
Contributor

hasura-bot commented Mar 25, 2019

Review app https://hge-ci-pull-1735.herokuapp.com is deleted

@chazgorman chazgorman mentioned this pull request Mar 27, 2019
Closed
hasura-bot pushed a commit that referenced this pull request Mar 17, 2025
@danieljharvey @hasura-bot
Collect multiple errors for even more steps (#1735)
922cd16 
<!-- The PR description should answer 2 important questions: -->

### What

This time, `scalar_boolean_expression_types` and `type_permissions`.

V3_GIT_ORIGIN_REV_ID: cea7c77f636ecca34559de2fdf57bacde4dcb247
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rakeshkky rakeshkky rakeshkky left review comments

@0x777 0x777 0x777 approved these changes

+2 more reviewers

@ecthiender ecthiender ecthiender left review comments

@rikinsk-zz rikinsk-zz rikinsk-zz approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

c/console Related to console c/docs Related to docs c/server Related to server s/ok-to-merge Status: This pull request can be merged to master

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@shahidhk @hasura-bot @coco98 @rikinsk-zz @ecthiender @0x777 @rakeshkky @rikinsk