这是indexloc提供的服务，不要输入任何密码
Skip to content

fix console raw SQL track this logic (close #1671, #1627) #1717

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Mar 13, 2019
Merged

fix console raw SQL track this logic (close #1671, #1627) #1717

merged 5 commits into from
Mar 13, 2019

Conversation

@rikinsk-zz
Copy link

@rikinsk-zz rikinsk-zz commented Mar 7, 2019

Description

Change logic for auto-enabling Track this checkbox in Raw SQL section

Affected components

  • Console

Related Issues

#1671, #1627

Solution and Design

  • Track this will be disabled if SQL contains a create function statement
  • Track this will be disabled if SQL contains a create table/view statement for a table/view which is already tracked

Steps to test and verify

Limitations, known bugs & workarounds

  • Doesn't detect if a table/view is tracked in a schema other than the current schema.

@rikinsk-zz rikinsk-zz requested a review from praveenweb as a code owner March 7, 2019 15:04
@hasura-bot
Copy link
Contributor

hasura-bot commented Mar 11, 2019

Review app for commit a725fd4 deployed to Heroku: https://hge-ci-pull-1717.herokuapp.com
Docker image for server: hasura/graphql-engine:pull1717-a725fd4

@rikinsk-zz rikinsk-zz requested a review from arvi3411301 March 12, 2019 13:25
dsandip
dsandip approved these changes Mar 13, 2019
View reviewed changes
Copy link
Member

@dsandip dsandip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functionality lgtm.

@rikinsk-zz rikinsk-zz merged commit f736ad2 into hasura:master Mar 13, 2019
@hasura-bot
Copy link
Contributor

hasura-bot commented Mar 13, 2019

Review app https://hge-ci-pull-1717.herokuapp.com is deleted

@rikinsk-zz rikinsk-zz deleted the console-track-this branch March 13, 2019 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dsandip dsandip dsandip approved these changes

@praveenweb praveenweb Awaiting requested review from praveenweb

@arvi3411301 arvi3411301 Awaiting requested review from arvi3411301

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@rikinsk-zz @hasura-bot @dsandip @rikinsk