这是indexloc提供的服务,不要输入任何密码
Skip to content

Conversation

@0x777
Copy link
Member

@0x777 0x777 commented Mar 1, 2019

The architecture is yet to be documented.

@0x777 0x777 requested a review from praveenweb as a code owner March 1, 2019 11:00
This was referenced Mar 1, 2019
@0x777
Copy link
Member Author

0x777 commented Apr 2, 2019

closing this in favor of #1934

@0x777 0x777 closed this Apr 2, 2019
@hasura-bot
Copy link
Contributor

Review app https://hge-ci-pull-1685.herokuapp.com is deleted

@0x777 0x777 deleted the subs-opt branch April 2, 2019 14:40
hasura-bot pushed a commit that referenced this pull request Mar 3, 2025
<!-- The PR description should answer 2 important questions: -->
### What
Validate the command/model argument types against mapped NDC argument
types.
- Check type structure compatibility; nullability & array containers.
- If field type is an OpenDd inbuilt type (Int, Boolean etc.), check if
mapped field type's NDC representation is compatible. E.g: `Float`
inbuilt type can only mapped to NDC `Float32` or `Float64`
representation.

Validation check is gated behind a compatibility flag. So, validation
failures are reported as warnings for current projects and as strict
build errors for projects created or compatibility date after the
released date of this change.

### How
- Use `type_validation::validate_type_compatibility` fn to validate
types along with issue collection.
- Update existing `metadata-resolve` tests metadata to avoid these
warnings. Add fresh tests to confirm these warnings.

V3_GIT_ORIGIN_REV_ID: 7a0a4a6c95b43897129f20cd0f66f030cd940a1d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants