-
Notifications
You must be signed in to change notification settings - Fork 2.8k
optimise the subscriptions infra #1685
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will help when we add caching of frequently used ASTs
This was referenced Mar 1, 2019
Closed
Member
Author
|
closing this in favor of #1934 |
Contributor
|
Review app https://hge-ci-pull-1685.herokuapp.com is deleted |
hasura-bot
pushed a commit
that referenced
this pull request
Mar 3, 2025
<!-- The PR description should answer 2 important questions: --> ### What Validate the command/model argument types against mapped NDC argument types. - Check type structure compatibility; nullability & array containers. - If field type is an OpenDd inbuilt type (Int, Boolean etc.), check if mapped field type's NDC representation is compatible. E.g: `Float` inbuilt type can only mapped to NDC `Float32` or `Float64` representation. Validation check is gated behind a compatibility flag. So, validation failures are reported as warnings for current projects and as strict build errors for projects created or compatibility date after the released date of this change. ### How - Use `type_validation::validate_type_compatibility` fn to validate types along with issue collection. - Update existing `metadata-resolve` tests metadata to avoid these warnings. Add fresh tests to confirm these warnings. V3_GIT_ORIGIN_REV_ID: 7a0a4a6c95b43897129f20cd0f66f030cd940a1d
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The architecture is yet to be documented.