-
Notifications
You must be signed in to change notification settings - Fork 2.8k
update event triggers on rename operations #1684
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Review app for commit 60a2968 deployed to Heroku: https://hge-ci-pull-1684.herokuapp.com |
|
Review app for commit d2e8fbe deployed to Heroku: https://hge-ci-pull-1684.herokuapp.com |
|
Review app for commit d204b14 deployed to Heroku: https://hge-ci-pull-1684.herokuapp.com |
|
Review app https://hge-ci-pull-1684.herokuapp.com is deleted |
<!-- The PR description should answer 2 important questions: -->
### What
Switch the benchmarks over to use the new pipeline. What are the
changes?
The bad news:
`Generate Query Plan` takes longer. This makes sense because it's doing
a lot more work now, going from a much more basic IR and adding all the
NDC concepts.
However, the good news:
`Generate IR` is a bit quicker, because it's not doing any NDC lookups
now I guess.
And the only thing that really matters:
`Total Execution Time`, the thing that ultimately matters to users, is
always down. In the run below it's more pronounced, but I ran it again
to be sure, and it was still consistently reduced.
```bash
simple_select/bench/Resolution of raw request
time: [584.01 ns 585.62 ns 588.19 ns]
change: [-2.3403% -1.9695% -1.5033%] (p = 0.00 < 0.05)
Performance has improved.
simple_select/bench_execute/Normalize request
time: [1.7330 µs 1.7367 µs 1.7426 µs]
change: [-2.9384% -2.5319% -2.1249%] (p = 0.00 < 0.05)
Performance has improved.
simple_select/bench_execute/Generate IR
time: [777.48 ns 778.23 ns 779.02 ns]
change: [-16.400% -16.252% -16.122%] (p = 0.00 < 0.05)
Performance has improved.
simple_select/bench_execute/Generate Query Plan
time: [1.5749 µs 1.5779 µs 1.5823 µs]
change: [+145.73% +146.48% +147.30%] (p = 0.00 < 0.05)
Performance has regressed.
simple_select/bench_execute/Execute Query Plan
time: [514.65 µs 524.54 µs 537.67 µs]
change: [-22.668% -20.056% -17.332%] (p = 0.00 < 0.05)
Performance has improved.
simple_select/bench_execute/Total Execution time
time: [580.06 µs 590.23 µs 604.08 µs]
change: [-33.223% -31.118% -28.701%] (p = 0.00 < 0.05)
Performance has improved.
```
```bash
select_many/bench/Resolution of raw request
time: [498.93 ns 499.81 ns 501.22 ns]
change: [-4.1599% -2.5510% -1.3041%] (p = 0.00 < 0.05)
Performance has improved.
select_many/bench_execute/Normalize request
time: [1.7185 µs 1.7296 µs 1.7447 µs]
change: [-2.9283% -1.1719% +0.2896%] (p = 0.15 > 0.05)
No change in performance detected.
select_many/bench_execute/Generate IR
time: [706.49 ns 706.93 ns 707.43 ns]
change: [-18.076% -17.355% -16.802%] (p = 0.00 < 0.05)
Performance has improved.
select_many/bench_execute/Generate Query Plan
time: [1.0737 µs 1.0812 µs 1.0914 µs]
change: [+77.778% +79.170% +81.086%] (p = 0.00 < 0.05)
Performance has regressed.
select_many/bench_execute/Execute Query Plan
time: [510.51 µs 516.41 µs 524.37 µs]
change: [-25.515% -23.970% -22.176%] (p = 0.00 < 0.05)
Performance has improved.
select_many/bench_execute/Total Execution time
time: [579.53 µs 584.23 µs 589.13 µs]
change: [-38.261% -35.126% -32.955%] (p = 0.00 < 0.05)
Performance has improved.
```
```bash
select_many_where/bench/Resolution of raw request
time: [4.8082 µs 4.8122 µs 4.8169 µs]
change: [-4.7438% -4.3075% -3.9870%] (p = 0.00 < 0.05)
Performance has improved.
select_many_where/bench_execute/Normalize request
time: [10.478 µs 10.497 µs 10.527 µs]
change: [-1.6147% -1.1719% -0.8263%] (p = 0.00 < 0.05)
Change within noise threshold.
select_many_where/bench_execute/Generate IR
time: [4.1107 µs 4.1139 µs 4.1176 µs]
change: [-22.653% -22.161% -21.865%] (p = 0.00 < 0.05)
Performance has improved.
select_many_where/bench_execute/Generate Query Plan
time: [13.202 µs 13.228 µs 13.267 µs]
change: [+334.24% +335.28% +336.43%] (p = 0.00 < 0.05)
Performance has regressed.
select_many_where/bench_execute/Execute Query Plan
time: [996.60 µs 1.0404 ms 1.0918 ms]
change: [-31.955% -27.646% -23.163%] (p = 0.00 < 0.05)
Performance has improved.
select_many_where/bench_execute/Total Execution time
time: [1.0767 ms 1.1030 ms 1.1371 ms]
change: [-43.496% -39.624% -35.988%] (p = 0.00 < 0.05)
Performance has improved.
```
```bash
object_relationship/bench/Resolution of raw request
time: [606.87 ns 607.22 ns 607.62 ns]
change: [-0.7308% -0.3614% -0.0855%] (p = 0.01 < 0.05)
Change within noise threshold.
object_relationship/bench_execute/Normalize request
time: [1.9355 µs 1.9390 µs 1.9447 µs]
change: [-1.6819% -1.4076% -1.0859%] (p = 0.00 < 0.05)
Performance has improved.
object_relationship/bench_execute/Generate IR
time: [787.18 ns 787.80 ns 788.51 ns]
change: [-34.239% -33.970% -33.787%] (p = 0.00 < 0.05)
Performance has improved.
object_relationship/bench_execute/Generate Query Plan
time: [2.3847 µs 2.3864 µs 2.3881 µs]
change: [+137.29% +138.45% +139.30%] (p = 0.00 < 0.05)
Performance has regressed.
object_relationship/bench_execute/Execute Query Plan
time: [681.21 µs 687.96 µs 695.21 µs]
change: [-20.128% -18.740% -17.319%] (p = 0.00 < 0.05)
Performance has improved.
object_relationship/bench_execute/Total Execution time
time: [788.93 µs 795.11 µs 801.44 µs]
change: [-25.155% -23.991% -22.853%] (p = 0.00 < 0.05)
Performance has improved.
```
```bash
array_relationship/bench/Resolution of raw request
time: [632.18 ns 633.36 ns 634.94 ns]
change: [-0.9229% -0.6355% -0.3073%] (p = 0.00 < 0.05)
Change within noise threshold.
array_relationship/bench_execute/Normalize request
time: [2.0085 µs 2.0124 µs 2.0175 µs]
change: [-1.3682% -0.9071% -0.5427%] (p = 0.00 < 0.05)
Change within noise threshold.
array_relationship/bench_execute/Generate IR
time: [852.19 ns 852.79 ns 853.48 ns]
change: [-39.888% -39.779% -39.671%] (p = 0.00 < 0.05)
Performance has improved.
array_relationship/bench_execute/Generate Query Plan
time: [2.8753 µs 2.8806 µs 2.8877 µs]
change: [+176.75% +177.41% +178.13%] (p = 0.00 < 0.05)
Performance has regressed.
array_relationship/bench_execute/Execute Query Plan
time: [665.83 µs 671.71 µs 678.06 µs]
change: [-97.622% -95.462% -88.482%] (p = 0.00 < 0.05)
Performance has improved.
array_relationship/bench_execute/Total Execution time
time: [759.55 µs 772.37 µs 788.08 µs]
change: [-99.729% -99.604% -99.344%] (p = 0.00 < 0.05)
Performance has improved.
```
```bash
relay_node_field/bench/Resolution of raw request
time: [473.83 ns 474.60 ns 475.89 ns]
change: [-2.0434% -1.3007% -0.7871%] (p = 0.00 < 0.05)
Change within noise threshold.
relay_node_field/bench_execute/Normalize request
time: [1.3993 µs 1.4018 µs 1.4051 µs]
change: [-1.0289% -0.8210% -0.5292%] (p = 0.00 < 0.05)
Change within noise threshold.
relay_node_field/bench_execute/Generate IR
time: [710.36 ns 710.84 ns 711.39 ns]
change: [-6.9873% -6.8421% -6.7018%] (p = 0.00 < 0.05)
Performance has improved.
relay_node_field/bench_execute/Generate Query Plan
time: [939.65 ns 941.12 ns 943.20 ns]
change: [+76.568% +77.273% +77.843%] (p = 0.00 < 0.05)
Performance has regressed.
relay_node_field/bench_execute/Execute Query Plan
time: [547.33 µs 551.25 µs 555.42 µs]
change: [-27.869% -26.048% -24.238%] (p = 0.00 < 0.05)
Performance has improved.
relay_node_field/bench_execute/Total Execution time
time: [635.99 µs 642.34 µs 649.56 µs]
change: [-24.242% -22.904% -21.602%] (p = 0.00 < 0.05)
Performance has improved.
```
V3_GIT_ORIGIN_REV_ID: 7ea4f03acea31e53d209a614ac97c3cd1e255c54
The previous PR didn't handle updating event trigger definitions on rename operations
Description
Affected components
Related Issues
Solution and Design
Steps to test and verify
Limitations, known bugs & workarounds