这是indexloc提供的服务,不要输入任何密码
Skip to content

Conversation

@wawhal
Copy link
Contributor

@wawhal wawhal commented Feb 28, 2019

Description

Add OneGraph Explorer to console. You can now see something like this in the console.

Affected components

  • Console

Related Issues

#1616

Solution and Design

  • Rendering OneGraphExplorer along with existing GraphiQL.
  • Added a Toggle Explorer button to hasura-console-graphiql (our own fork of GraphiQL)

Steps to test and verify

Click on the toggle explorer button.

Limitations, known bugs & workarounds

@wawhal wawhal requested a review from praveenweb as a code owner February 28, 2019 18:22
@coco98
Copy link
Contributor

coco98 commented Mar 1, 2019

@wawhal @shahidhk @arvi3411301 Why don't we have a heroku build for this yet?

@arvi3411301
Copy link
Member

@coco98 console build is failed for the latest commit.

@hasura-bot
Copy link
Contributor

Review app for commit 0e8b69c deployed to Heroku: https://hge-ci-pull-1680.herokuapp.com
Docker image for server: hasura/graphql-engine:pull1680-0e8b69c

@shahidhk
Copy link
Member

shahidhk commented Mar 1, 2019

There is a scroll bar on the Explorer header.
https://screenshots.firefox.com/XIuiyjwZ8DG6z5jE/hge-ci-pull-1680.herokuapp.com

Also, shouldn't we say OneGraphiQL somewhere?

@hasura-bot
Copy link
Contributor

Review app for commit fa154d8 deployed to Heroku: https://hge-ci-pull-1680.herokuapp.com
Docker image for server: hasura/graphql-engine:pull1680-fa154d8

@hasura-bot
Copy link
Contributor

Review app for commit 3e2e688 deployed to Heroku: https://hge-ci-pull-1680.herokuapp.com
Docker image for server: hasura/graphql-engine:pull1680-3e2e688

@shahidhk
Copy link
Member

shahidhk commented Mar 7, 2019

Explorer is super awesome! One tiny feedback that I have is - missing the ability to resize the width of the Explorer column. It is too big for small schemas and takes up a lot of space.

@wawhal

@coco98
Copy link
Contributor

coco98 commented Mar 7, 2019 via email

@wawhal wawhal requested a review from rikinsk-zz as a code owner March 15, 2019 13:18
@hasura-bot
Copy link
Contributor

Review app for commit 58db8eb deployed to Heroku: https://hge-ci-pull-1680.herokuapp.com
Docker image for server: hasura/graphql-engine:pull1680-58db8eb

@wawhal wawhal added k/enhancement New feature or improve an existing feature s/ok-to-merge Status: This pull request can be merged to master c/console Related to console labels Mar 18, 2019
@rikinsk-zz rikinsk-zz merged commit 3d81e02 into hasura:master Mar 18, 2019
@hasura-bot
Copy link
Contributor

Review app https://hge-ci-pull-1680.herokuapp.com is deleted

hasura-bot pushed a commit that referenced this pull request Feb 27, 2025
<!-- The PR description should answer 2 important questions: -->

### What

They all run, so remove the flag. Functional no-op.

V3_GIT_ORIGIN_REV_ID: 243f31d304842d24b60592acce9e65491d1ae69b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c/console Related to console k/enhancement New feature or improve an existing feature s/ok-to-merge Status: This pull request can be merged to master

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants