这是indexloc提供的服务，不要输入任何密码
Skip to content

Console refactor #1688

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 32 commits into from
Mar 6, 2019
Merged

Console refactor #1688

merged 32 commits into from
Mar 6, 2019

Conversation

@rikinsk-zz
Copy link

@rikinsk-zz rikinsk-zz commented Mar 1, 2019 •
edited
Loading

Description

Lots of random refactoring mainly revolving around:

  • Removing duplicate css
  • Reorganising common code

Affected components

  • Console

Related Issues

Solution and Design

Steps to test and verify

Limitations, known bugs & workarounds

@hasura-bot
Copy link
Contributor

hasura-bot commented Mar 1, 2019

Review app for commit 7afa580 deployed to Heroku: https://hge-ci-pull-1688.herokuapp.com
Docker image for server: hasura/graphql-engine:pull1688-7afa580

@hasura-bot
Copy link
Contributor

hasura-bot commented Mar 4, 2019

Review app for commit 2a63989 deployed to Heroku: https://hge-ci-pull-1688.herokuapp.com
Docker image for server: hasura/graphql-engine:pull1688-2a63989

@hasura-bot
Copy link
Contributor

hasura-bot commented Mar 4, 2019

Review app for commit 95289eb deployed to Heroku: https://hge-ci-pull-1688.herokuapp.com
Docker image for server: hasura/graphql-engine:pull1688-95289eb

@rikinsk-zz rikinsk-zz marked this pull request as ready for review March 4, 2019 14:35
@rikinsk-zz rikinsk-zz requested a review from praveenweb as a code owner March 4, 2019 14:35
@rikinsk-zz rikinsk-zz added the s/do-not-merge Do not merge this pull request to master label Mar 5, 2019
@rikinsk-zz rikinsk-zz removed the s/do-not-merge Do not merge this pull request to master label Mar 5, 2019
@hasura-bot
Copy link
Contributor

hasura-bot commented Mar 5, 2019

Review app for commit e31211e deployed to Heroku: https://hge-ci-pull-1688.herokuapp.com
Docker image for server: hasura/graphql-engine:pull1688-e31211e

@hasura-bot
Copy link
Contributor

hasura-bot commented Mar 5, 2019

Review app for commit ac4d562 deployed to Heroku: https://hge-ci-pull-1688.herokuapp.com
Docker image for server: hasura/graphql-engine:pull1688-ac4d562

@hasura-bot
Copy link
Contributor

hasura-bot commented Mar 6, 2019

Review app for commit f3dc32c deployed to Heroku: https://hge-ci-pull-1688.herokuapp.com
Docker image for server: hasura/graphql-engine:pull1688-f3dc32c

@hasura-bot
Copy link
Contributor

hasura-bot commented Mar 6, 2019

Review app for commit cdce30d deployed to Heroku: https://hge-ci-pull-1688.herokuapp.com
Docker image for server: hasura/graphql-engine:pull1688-cdce30d

@rikinsk-zz rikinsk-zz merged commit 06afb75 into hasura:master Mar 6, 2019
@hasura-bot
Copy link
Contributor

hasura-bot commented Mar 6, 2019

Review app https://hge-ci-pull-1688.herokuapp.com is deleted

@rikinsk-zz rikinsk-zz deleted the console-refactor branch March 6, 2019 11:30
@hasura-bot
Copy link
Contributor

hasura-bot commented Mar 6, 2019

Review app for commit 418e3ba deployed to Heroku: https://hge-ci-pull-1688.herokuapp.com
Docker image for server: hasura/graphql-engine:pull1688-418e3ba

hasura-bot pushed a commit that referenced this pull request Mar 5, 2025
@danieljharvey @hasura-bot
Diff execution plans in tests (#1688)
06821e5 
<!-- The PR description should answer 2 important questions: -->

### What

All the tests were passing, but since we're going to diff execution
plans in prod, need to remove false positives, so this PR changes our
engine tests to diff execution plans between old and new pipelines.

We fix everything to make these pass. Next step is to actually run these
in prod and emit traces for failures.

V3_GIT_ORIGIN_REV_ID: 289e07016b6210d052736697ca3c71760ebade40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@praveenweb praveenweb praveenweb approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@rikinsk-zz @hasura-bot @praveenweb @rikinsk