这是indexloc提供的服务,不要输入任何密码
Skip to content

Conversation

@wawhal
Copy link
Contributor

@wawhal wawhal commented Feb 28, 2019

Description

This PR adds "*" as columns for insert and delete so that there are no column dependencies on event triggers and users can drop/modify columns whenever they want.

Affected components

  • Console

Related Issues

#1629

Solution and Design

{
	"type": "bulk",
	"args": [{
		"type": "create_event_trigger",
		"args": {
			"name": "test",
			"table": {
				"name": "user",
				"schema": "public"
			},
			"webhook": "http://httpbin.org/post",
			"insert": {
				"columns": "*"
			},
                        "update": {
                               "columns": ["col1", "col2"] 
                       },
                       "delete": {
                               "columns": "*"
                       }
			"headers": []
		}
	}]
}

Steps to test and verify

  1. Create trigger, try dropping columns
  2. Modify trigger, try dropping columns

Limitations, known bugs & workarounds

@wawhal wawhal added the k/bug Something isn't working label Feb 28, 2019
@wawhal wawhal requested a review from praveenweb as a code owner February 28, 2019 06:24
@hasura-bot
Copy link
Contributor

Review app for commit 069b145 deployed to Heroku: https://hge-ci-pull-1673.herokuapp.com
Docker image for server: hasura/graphql-engine:pull1673-069b145

@praveenweb praveenweb added the s/ok-to-merge Status: This pull request can be merged to master label Mar 1, 2019
Copy link
Contributor

@tirumaraiselvan tirumaraiselvan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@arvi3411301 tested and approved

@wawhal wawhal added the c/console Related to console label Mar 1, 2019
@shahidhk shahidhk changed the title add "*" for insert and delete columns while creating and modifying trigger add "*" for insert and delete columns when creating and modifying trigger (close #1629) Mar 1, 2019
@shahidhk shahidhk merged commit 0022772 into hasura:master Mar 1, 2019
@hasura-bot
Copy link
Contributor

Review app https://hge-ci-pull-1673.herokuapp.com is deleted

@wawhal wawhal changed the title add "*" for insert and delete columns when creating and modifying trigger (close #1629) add "*" for insert and delete columns while creating and modifying trigger (closes #1629) Mar 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c/console Related to console k/bug Something isn't working s/ok-to-merge Status: This pull request can be merged to master

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants