这是indexloc提供的服务，不要输入任何密码
Skip to content

enforce column presets of update permission with upserts (fix #1647) #1653

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 23, 2019
Merged

enforce column presets of update permission with upserts (fix #1647) #1653

merged 3 commits into from
Feb 23, 2019

Conversation

@rakeshkky
Copy link
Member

@rakeshkky rakeshkky commented Feb 22, 2019

Description

What component does this PR affect?

  • Server
  • Console
  • CLI
  • Docs
  • Community Content
  • Build System

Requires changes from other components? If yes, please mark the components:

  • Server
  • Console
  • CLI
  • Docs
  • Community Content
  • Build System

Related Issue

fix #1647

Solution and Design

Combine preset expressions of update permission with set expression of upsert (... ON CONFLICT <constraint> DO UPDATE SET ...)

Type

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Docs update
  • Community content

Checklist:

  • I have read the contributing guide and my code conforms to the guidelines.
  • This change requires a change in the documentation.
  • I have updated the documentation accordingly.
  • I have added required tests.

@rakeshkky rakeshkky added s/ok-to-merge Status: This pull request can be merged to master c/server Related to server labels Feb 22, 2019
@rakeshkky rakeshkky self-assigned this Feb 22, 2019
@rakeshkky rakeshkky requested a review from 0x777 February 22, 2019 12:44
@rakeshkky rakeshkky changed the title enforce column presets of update permission with upserts enforce column presets of update permission with upserts (fix #1647) Feb 22, 2019
@hasura-bot
Copy link
Contributor

hasura-bot commented Feb 22, 2019

Review app for commit 99a47e6 deployed to Heroku: https://hge-ci-pull-1653.herokuapp.com
Docker image for server: hasura/graphql-engine:pull1653-99a47e6

@hasura-bot
Copy link
Contributor

hasura-bot commented Feb 23, 2019

Review app for commit 04c2119 deployed to Heroku: https://hge-ci-pull-1653.herokuapp.com
Docker image for server: hasura/graphql-engine:pull1653-04c2119

@0x777 0x777 merged commit c731fde into hasura:master Feb 23, 2019
@hasura-bot
Copy link
Contributor

hasura-bot commented Feb 23, 2019

Review app https://hge-ci-pull-1653.herokuapp.com is deleted

hasura-bot pushed a commit that referenced this pull request Feb 20, 2025
@rakeshkky @hasura-bot
Revert "GraphQL: Don't include "data" field in errors raised before e…
73bff9a 
…xecution (#1645)" (#1653)

This reverts commit ddacaf63585b5afba67d88b3d820be2af0adf027.

### What

To unblock failing e2e tests for next release.

V3_GIT_ORIGIN_REV_ID: 0269361c09374d16325229c9231fc465a0205a1a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@0x777 0x777 0x777 approved these changes

Assignees

@rakeshkky rakeshkky

Labels

c/server Related to server s/ok-to-merge Status: This pull request can be merged to master

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

column presets are not enforced with upserts

3 participants

@rakeshkky @hasura-bot @0x777