这是indexloc提供的服务，不要输入任何密码
Skip to content

update console permissions #1658

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Feb 28, 2019
Merged

update console permissions #1658

merged 5 commits into from
Feb 28, 2019

Conversation

@rikinsk-zz
Copy link

@rikinsk-zz rikinsk-zz commented Feb 25, 2019

Description

  • removed trash icon to remove all permissions. Same action can be done via the bulk section
  • colour coded permissions symbols for better visual feedback

What component does this PR affect?

  • Server
  • Console
  • CLI
  • Docs
  • Community Content
  • Build System

Requires changes from other components? If yes, please mark the components:

  • Server
  • Console
  • CLI
  • Docs
  • Community Content
  • Build System

Related Issue

Solution and Design

Type

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Docs update
  • Community content

Checklist:

  • I have read the contributing guide and my code conforms to the guidelines.
  • This change requires a change in the documentation.
  • I have updated the documentation accordingly.
  • I have added required tests.

@rikinsk-zz rikinsk-zz changed the title Console permissions update console permissions Feb 25, 2019
@hasura-bot
Copy link
Contributor

hasura-bot commented Feb 25, 2019

Review app for commit 92340ab deployed to Heroku: https://hge-ci-pull-1658.herokuapp.com
Docker image for server: hasura/graphql-engine:pull1658-92340ab

@hasura-bot
Copy link
Contributor

hasura-bot commented Feb 25, 2019

Review app for commit 60d8909 deployed to Heroku: https://hge-ci-pull-1658.herokuapp.com
Docker image for server: hasura/graphql-engine:pull1658-60d8909

praveenweb
praveenweb approved these changes Feb 28, 2019
View reviewed changes
Copy link
Member

@praveenweb praveenweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Depending on feedback, we can bring back trash icon in a different form in a later update.

@hasura-bot
Copy link
Contributor

hasura-bot commented Feb 28, 2019

Review app for commit 8d6658f deployed to Heroku: https://hge-ci-pull-1658.herokuapp.com
Docker image for server: hasura/graphql-engine:pull1658-8d6658f

@rikinsk-zz rikinsk-zz merged commit 214cdeb into hasura:master Feb 28, 2019
@hasura-bot
Copy link
Contributor

hasura-bot commented Feb 28, 2019

Review app https://hge-ci-pull-1658.herokuapp.com is deleted

@rikinsk-zz rikinsk-zz deleted the console-permissions branch February 28, 2019 14:52
@hasura-bot
Copy link
Contributor

hasura-bot commented Feb 28, 2019

Review app for commit 92baf9c deployed to Heroku: https://hge-ci-pull-1658.herokuapp.com
Docker image for server: hasura/graphql-engine:pull1658-92baf9c

hasura-bot pushed a commit that referenced this pull request Feb 21, 2025
@paritosh-08 @hasura-bot
add check for command output type (#1658)
83046cd 
<!-- The PR description should answer 2 important questions: -->

### What

Add validation for command output types

This PR adds validation to ensure that command output types reference
valid types in the schema.
A new flag `require_valid_command_output_type` is introduced to control
this behavior.

### How

Key changes:
- Add validation in command resolution to check if output type exists
- Add new `InvalidCommandOutputType` issue type
- Add new compatibility flag `RequireValidCommandOutputType`
(compatibility date TBD)
- Add tests for invalid output type case

V3_GIT_ORIGIN_REV_ID: 88bd30a09431ce85c2d7b68e7aba507508088bcb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@praveenweb praveenweb praveenweb approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@rikinsk-zz @hasura-bot @praveenweb @rikinsk