这是indexloc提供的服务，不要输入任何密码
Skip to content

fix console sidebar links highlighting #1657

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Feb 26, 2019
Merged

fix console sidebar links highlighting #1657

merged 4 commits into from
Feb 26, 2019

Conversation

@rikinsk-zz
Copy link

@rikinsk-zz rikinsk-zz commented Feb 25, 2019

Description

  • Highlight console left sidebar links
  • Fix event triggers/remote schema redirects

What component does this PR affect?

  • Server
  • Console
  • CLI
  • Docs
  • Community Content
  • Build System

Requires changes from other components? If yes, please mark the components:

  • Server
  • Console
  • CLI
  • Docs
  • Community Content
  • Build System

Related Issue

Solution and Design

Type

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Docs update
  • Community content

Checklist:

  • I have read the contributing guide and my code conforms to the guidelines.
  • This change requires a change in the documentation.
  • I have updated the documentation accordingly.
  • I have added required tests.

@hasura-bot
Copy link
Contributor

hasura-bot commented Feb 25, 2019

Review app for commit 5cf6755 deployed to Heroku: https://hge-ci-pull-1657.herokuapp.com
Docker image for server: hasura/graphql-engine:pull1657-5cf6755

@hasura-bot
Copy link
Contributor

hasura-bot commented Feb 25, 2019

Review app for commit 8a443f2 deployed to Heroku: https://hge-ci-pull-1657.herokuapp.com
Docker image for server: hasura/graphql-engine:pull1657-8a443f2

@rikinsk-zz rikinsk-zz merged commit e5290d4 into hasura:master Feb 26, 2019
@hasura-bot
Copy link
Contributor

hasura-bot commented Feb 26, 2019

Review app https://hge-ci-pull-1657.herokuapp.com is deleted

@rikinsk-zz rikinsk-zz deleted the console-sidebar branch February 26, 2019 07:04
hasura-bot pushed a commit that referenced this pull request Feb 21, 2025
@paritosh-08 @hasura-bot
fix format for nix >= 2.25 (#1657)
b4df238 
We need to specify the path in `nix fmt` after nix 2.25.0

> Removing the default argument passed to the nix fmt formatted.
>
> The underlying formatter no longer receives the “.” default argument
when nix fmt is called with no arguments.

https://discourse.nixos.org/t/nix-2-25-released/55994

V3_GIT_ORIGIN_REV_ID: ef1999ebc2cb9c71ed1fca402b5d83eb360a0881
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@praveenweb praveenweb praveenweb approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@rikinsk-zz @hasura-bot @praveenweb @rikinsk