这是indexloc提供的服务，不要输入任何密码
Skip to content

update console browse rows section #1642

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 13 commits into from
Feb 28, 2019
Merged

update console browse rows section #1642

merged 13 commits into from
Feb 28, 2019

Conversation

@rikinsk-zz
Copy link

@rikinsk-zz rikinsk-zz commented Feb 20, 2019 •
edited
Loading

Description

  • Update browse rows UI
  • Make columns draggable
  • Make columns collapsible
  • Allow multiple columns sort using headers
  • Add no sort option while toggling

What component does this PR affect?

  • Server
  • Console
  • CLI
  • Docs
  • Community Content
  • Build System

Requires changes from other components? If yes, please mark the components:

  • Server
  • Console
  • CLI
  • Docs
  • Community Content
  • Build System

Related Issue

#1622

Solution and Design

Type

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Docs update
  • Community content

Checklist:

  • I have read the contributing guide and my code conforms to the guidelines.
  • This change requires a change in the documentation.
  • I have updated the documentation accordingly.
  • I have added required tests.

@hasura-bot
Copy link
Contributor

hasura-bot commented Feb 20, 2019

Review app for commit b137d86 deployed to Heroku: https://hge-ci-pull-1642.herokuapp.com
Docker image for server: hasura/graphql-engine:pull1642-b137d86

@hasura-bot
Copy link
Contributor

hasura-bot commented Feb 20, 2019

Review app for commit a179b15 deployed to Heroku: https://hge-ci-pull-1642.herokuapp.com
Docker image for server: hasura/graphql-engine:pull1642-a179b15

@hasura-bot
Copy link
Contributor

hasura-bot commented Feb 20, 2019

Review app for commit d5efb7a deployed to Heroku: https://hge-ci-pull-1642.herokuapp.com
Docker image for server: hasura/graphql-engine:pull1642-d5efb7a

@praveenweb
Copy link
Member

praveenweb commented Feb 21, 2019

@rikinsk - Hovering over sort icon gives me expand icon and its slightly confusing. Basically the sort icon is just for indication but sort works by clicking anywhere, but the icon.

@hasura-bot
Copy link
Contributor

hasura-bot commented Feb 22, 2019

Review app for commit 6fa32dd deployed to Heroku: https://hge-ci-pull-1642.herokuapp.com
Docker image for server: hasura/graphql-engine:pull1642-6fa32dd

@hasura-bot
Copy link
Contributor

hasura-bot commented Feb 23, 2019

Review app for commit 5e18875 deployed to Heroku: https://hge-ci-pull-1642.herokuapp.com
Docker image for server: hasura/graphql-engine:pull1642-5e18875

@hasura-bot
Copy link
Contributor

hasura-bot commented Feb 23, 2019

Review app for commit db7439a deployed to Heroku: https://hge-ci-pull-1642.herokuapp.com
Docker image for server: hasura/graphql-engine:pull1642-db7439a

@hasura-bot
Copy link
Contributor

hasura-bot commented Feb 25, 2019

Review app for commit c015ad9 deployed to Heroku: https://hge-ci-pull-1642.herokuapp.com
Docker image for server: hasura/graphql-engine:pull1642-c015ad9

@hasura-bot
Copy link
Contributor

hasura-bot commented Feb 25, 2019

Review app for commit a5afebb deployed to Heroku: https://hge-ci-pull-1642.herokuapp.com
Docker image for server: hasura/graphql-engine:pull1642-a5afebb

praveenweb
praveenweb previously approved these changes Feb 28, 2019
View reviewed changes
Copy link
Member

@praveenweb praveenweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested functionality. Works fine.

May be we can do icon/ minor css changes in a later update based on feedback.

@hasura-bot
Copy link
Contributor

hasura-bot commented Feb 28, 2019

Review app for commit 41ec134 deployed to Heroku: https://hge-ci-pull-1642.herokuapp.com
Docker image for server: hasura/graphql-engine:pull1642-41ec134

@rikinsk-zz rikinsk-zz merged commit 2783561 into hasura:master Feb 28, 2019
@hasura-bot
Copy link
Contributor

hasura-bot commented Feb 28, 2019

Review app https://hge-ci-pull-1642.herokuapp.com is deleted

@rikinsk-zz rikinsk-zz deleted the console-browse-rows-update branch February 28, 2019 14:50
@hasura-bot
Copy link
Contributor

hasura-bot commented Feb 28, 2019

Review app for commit 2a83990 deployed to Heroku: https://hge-ci-pull-1642.herokuapp.com
Docker image for server: hasura/graphql-engine:pull1642-2a83990

@rikinsk-zz rikinsk-zz restored the console-browse-rows-update branch March 1, 2019 07:53
@rikinsk-zz rikinsk-zz deleted the console-browse-rows-update branch March 1, 2019 07:57
hasura-bot pushed a commit that referenced this pull request Feb 18, 2025
@daniel-chambers @hasura-bot
Enable engine tests to run on the NDC 0.2.0 Postgres connector (#1642)
bb303c1 
### What
This PR enables many engine tests to run across both the NDC 0.1.6 and
NDC 0.2.0 of the Postgres connector.

### How
A new service was added to the docker-compose that represents the new
NDC 0.2.0 (the existing service was renamed) and the justfile updated to
start both.

A new DataConnectorLink file was added to capture the 0.2.0 Postgres
connector: `postgres_connector_ndc_v02_schema.json`. The existing file
was renamed to `postgres_connector_ndc_v01_schema.json`.

Most tests simply needed to be run while swapping out the
DataConnectorLink. Some, in particular the aggregation tests, needed
tweaks where separate metadata is required between the two NDC versions
(because in NDC 0.2.0 the aggregate count type changed from Int32 to
Int64 for Postgres).

V3_GIT_ORIGIN_REV_ID: 22bfb4fdb588730adfb7ec96e4bab8811c56bc93
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@praveenweb praveenweb praveenweb approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@rikinsk-zz @hasura-bot @praveenweb @rikinsk