这是indexloc提供的服务，不要输入任何密码
Skip to content

generate scalar types for SQL function arguments (fix #1632) #1633

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Feb 22, 2019
Merged

generate scalar types for SQL function arguments (fix #1632) #1633

merged 4 commits into from
Feb 22, 2019

Conversation

@rakeshkky
Copy link
Member

@rakeshkky rakeshkky commented Feb 20, 2019

Description

What component does this PR affect?

  • Server
  • Console
  • CLI
  • Docs
  • Community Content
  • Build System

Requires changes from other components? If yes, please mark the components:

  • Server
  • Console
  • CLI
  • Docs
  • Community Content
  • Build System

Related Issue

fix #1632

Solution and Design

It's a fix to the bug reported by cherre on discord.

Scalar types are missing for SQL function arguments in <func-name>_args input type in SQL function query field.
This change makes server to generate FieldMap from SQL function arguments. FieldMap is later used to make scalar types.

Type

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Docs update
  • Community content

Checklist:

  • I have read the contributing guide and my code conforms to the guidelines.
  • This change requires a change in the documentation.
  • I have updated the documentation accordingly.
  • I have added required tests.

@rakeshkky rakeshkky added s/ok-to-merge Status: This pull request can be merged to master c/server Related to server labels Feb 20, 2019
@rakeshkky rakeshkky self-assigned this Feb 20, 2019
@rakeshkky rakeshkky requested a review from 0x777 February 20, 2019 08:32
@hasura-bot
Copy link
Contributor

hasura-bot commented Feb 20, 2019

Review app for commit bc5b5f8 deployed to Heroku: https://hge-ci-pull-1633.herokuapp.com
Docker image for server: hasura/graphql-engine:pull1633-bc5b5f8

@hasura-bot
Copy link
Contributor

hasura-bot commented Feb 21, 2019

Review app for commit cdf465e deployed to Heroku: https://hge-ci-pull-1633.herokuapp.com
Docker image for server: hasura/graphql-engine:pull1633-cdf465e

@hasura-bot
Copy link
Contributor

hasura-bot commented Feb 22, 2019

Review app for commit b7a0614 deployed to Heroku: https://hge-ci-pull-1633.herokuapp.com
Docker image for server: hasura/graphql-engine:pull1633-b7a0614

@0x777 0x777 merged commit 0833d35 into hasura:master Feb 22, 2019
@hasura-bot
Copy link
Contributor

hasura-bot commented Feb 22, 2019

Review app https://hge-ci-pull-1633.herokuapp.com is deleted

@Allymahmoud Allymahmoud mentioned this pull request Jun 27, 2023
Open
hasura-bot pushed a commit that referenced this pull request Feb 21, 2025
@danieljharvey @hasura-bot
Upgrade to Rust 1.84.1 (#1633)
ab551bb 
<!-- The PR description should answer 2 important questions: -->

### What

...and fix new clippy suggestions. Functional no-op.

V3_GIT_ORIGIN_REV_ID: ccd202e34224cd6ee102fc028c0102bc071c7c92
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@0x777 0x777 0x777 approved these changes

Assignees

@rakeshkky rakeshkky

Labels

c/server Related to server s/ok-to-merge Status: This pull request can be merged to master

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

generate scalar types for SQL function arguments

3 participants

@rakeshkky @hasura-bot @0x777