Schema and event triggers page update #1630

surendran82 · 2019-02-20T06:36:21Z

fix int-#76

Description

Updated landing for remote schema and event trigger

What component does this PR affect?

Requires changes from other components? If yes, please mark the components:

Related Issue

Solution and Design

Type

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to change)
Docs update
Community content

Checklist:

I have read the contributing guide and my code conforms to the guidelines.
This change requires a change in the documentation.
I have updated the documentation accordingly.
I have added required tests.

hasura-bot · 2019-02-20T07:15:29Z

Review app for commit 04858b7 deployed to Heroku: https://hge-ci-pull-1630.herokuapp.com
Docker image for server: hasura/graphql-engine:pull1630-04858b7

hasura-bot · 2019-02-20T10:24:54Z

Review app for commit 7d79c8a deployed to Heroku: https://hge-ci-pull-1630.herokuapp.com
Docker image for server: hasura/graphql-engine:pull1630-7d79c8a

hasura-bot · 2019-02-28T07:49:16Z

Review app for commit 3770890 deployed to Heroku: https://hge-ci-pull-1630.herokuapp.com
Docker image for server: hasura/graphql-engine:pull1630-3770890

hasura-bot · 2019-02-28T11:57:19Z

Review app for commit 63766b0 deployed to Heroku: https://hge-ci-pull-1630.herokuapp.com
Docker image for server: hasura/graphql-engine:pull1630-63766b0

hasura-bot · 2019-02-28T19:48:32Z

Review app for commit d4804a6 deployed to Heroku: https://hge-ci-pull-1630.herokuapp.com
Docker image for server: hasura/graphql-engine:pull1630-d4804a6

hasura-bot · 2019-03-01T08:34:29Z

Review app for commit 107d36a deployed to Heroku: https://hge-ci-pull-1630.herokuapp.com
Docker image for server: hasura/graphql-engine:pull1630-107d36a

… issue-76

tirumaraiselvan · 2019-03-01T13:27:14Z

@surendran82 can you close this DRAFT PR and open a normal one?

hasura-bot · 2019-03-01T14:22:48Z

Review app for commit 0ab82f6 deployed to Heroku: https://hge-ci-pull-1630.herokuapp.com
Docker image for server: hasura/graphql-engine:pull1630-0ab82f6

…last line text change

hasura-bot · 2019-03-05T16:11:15Z

Review app for commit d1a7173 deployed to Heroku: https://hge-ci-pull-1630.herokuapp.com
Docker image for server: hasura/graphql-engine:pull1630-d1a7173

coco98 · 2019-03-05T23:37:19Z

Suggestions:

Remove first section on what is remote schema if there's >=1 remote schema. Same for event triggers
The glitch page leads to the readme, which is empty. Let's put some instructions there.

hasura-bot · 2019-03-06T08:12:54Z

Review app for commit e3851ff deployed to Heroku: https://hge-ci-pull-1630.herokuapp.com
Docker image for server: hasura/graphql-engine:pull1630-e3851ff

hasura-bot · 2019-03-06T10:27:52Z

Review app for commit c405ff4 deployed to Heroku: https://hge-ci-pull-1630.herokuapp.com
Docker image for server: hasura/graphql-engine:pull1630-c405ff4

praveenweb · 2019-03-06T10:50:56Z

console/src/components/Services/CustomResolver/Landing/CustomResolver.js

-    const { dispatch, migrationMode } = this.props;
+    const { dispatch, migrationMode, customResolverList } = this.props;
+    const showFirstSection = customResolverList.resolvers.length ? false : true;
+    console.log(showFirstSection);


Remove console.log

praveenweb · 2019-03-06T10:51:40Z

console/src/components/Services/CustomResolver/Landing/CustomResolver.js

+    const node = require('./Node.svg');
+    const Rectangle = require('./Rectangle.svg');
+
+    // const lightGrayArrow = require('./light-gray-arrow.svg');


remove source image if its part of code

praveenweb

Remove images, console.log

hasura-bot · 2019-03-06T13:24:10Z

Review app for commit 5f6a0d7 deployed to Heroku: https://hge-ci-pull-1630.herokuapp.com
Docker image for server: hasura/graphql-engine:pull1630-5f6a0d7

Conflicts: console/src/components/Common/Common.scss console/src/components/Common/TextAreaWithCopy/TextAreaWithCopy.js console/src/components/Common/TextAreaWithCopy/TextAreaWithCopy.scss console/src/components/Services/CustomResolver/CustomResolver.scss console/src/components/Services/CustomResolver/Landing/CustomResolver.js console/src/components/Services/EventTrigger/Add/AddTrigger.js console/src/components/Services/EventTrigger/Schema/Schema.js

hasura-bot · 2019-03-07T12:22:05Z

Review app for commit b7980f0 deployed to Heroku: https://hge-ci-pull-1630.herokuapp.com
Docker image for server: hasura/graphql-engine:pull1630-b7980f0

… issue-76

hasura-bot · 2019-03-07T13:04:46Z

Review app https://hge-ci-pull-1630.herokuapp.com is deleted

hasura-bot · 2019-03-07T13:31:17Z

Review app for commit d951423 deployed to Heroku: https://hge-ci-pull-1630.herokuapp.com
Docker image for server: hasura/graphql-engine:pull1630-d951423

### What In GraphQL websockets, client headers from the handshake request are ignored. It made subscriptions unusable in private DDN setup where gateway sets `x-ddn-*` headers useful to authenticate the requests using PAT in webhooks. This PR address this issue by involving all client headers received from handshake in webhook request. These headers also included in other upstream requests (plugins, NDC etc.). ### How - Persist handshake headers in websocket connection context. Use them while authenticating `connection_init` message. - Add tests to confirm this behavior.  V3_GIT_ORIGIN_REV_ID: ab75af9803f6acd7634ec3ed63861a057a5c2c5c

Schema and event triggers page update

04858b7

dsandip changed the title ~~Schema and event triggers page update~~ Schema and event triggers page update (closes hasura/graphql-engine-internal#76) Feb 20, 2019

dsandip changed the title ~~Schema and event triggers page update (closes hasura/graphql-engine-internal#76)~~ Schema and event triggers page update ( closes hasura/graphql-engine-internal#76 ) Feb 20, 2019

dsandip changed the title ~~Schema and event triggers page update ( closes hasura/graphql-engine-internal#76 )~~ Schema and event triggers page update Feb 20, 2019

tirumaraiselvan and others added 2 commits February 20, 2019 14:51

text changes (#2)

c0c7004

node logo update

7d79c8a

Remote schema page WIP

3770890

Remote schema page ui WIP

63766b0

Remote schema page WIP

d4804a6

surendran82 added 2 commits March 1, 2019 12:56

remote schema page new design ui update

70d0ea3

remote schema image url update

107d36a

surendran82 and others added 8 commits March 1, 2019 16:57

event trigger and remote schema pages update

3e9dd37

change description

3d79b1a

change content

d7239b3

Links update for common

1db2c18

Merge branch 'issue-76' of github.com:surendran82/graphql-engine into…

4a62312

… issue-76

Links update for common

2ee1f6b

popup header text update

f0b3489

change glitch links

0ab82f6

surendran82 added 2 commits March 5, 2019 12:48

Remote schame page button text change and event trigger instructions …

a4c53c5

…last line text change

conflict fix

1f32f6e

surendran82 marked this pull request as ready for review March 5, 2019 07:26

update link

d1a7173

first section removed from remote schema and event trigger page

e3851ff

Event trigger and remote schema page update

c405ff4

praveenweb reviewed Mar 6, 2019

View reviewed changes

praveenweb requested changes Mar 6, 2019

View reviewed changes

remove unwanted images and console.log

5f6a0d7

rikinsk added 4 commits March 7, 2019 16:35

resolved merge issues

6deac80

fix css syntax

0f75cbc

Merge branch 'master' into issue-76

b7980f0

tirumaraiselvan previously approved these changes Mar 7, 2019

View reviewed changes

rikinsk added 3 commits March 7, 2019 18:10

update button texts

63cdd30

Merge branch 'issue-76' of github.com:surendran82/graphql-engine into…

629f01c

… issue-76

Merge branch 'master' into issue-76

552a544

rikinsk-zz dismissed tirumaraiselvan’s stale review via 552a544 March 7, 2019 12:42

tirumaraiselvan previously approved these changes Mar 7, 2019

View reviewed changes

update button txt

d951423

rikinsk-zz dismissed tirumaraiselvan’s stale review via d951423 March 7, 2019 12:50

praveenweb approved these changes Mar 7, 2019

View reviewed changes

rikinsk-zz merged commit 6a4a33f into hasura:master Mar 7, 2019

Schema and event triggers page update #1630

Schema and event triggers page update #1630

Uh oh!

Conversation

surendran82 commented Feb 20, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Related Issue

Solution and Design

Type

Checklist:

Uh oh!

hasura-bot commented Feb 20, 2019

Uh oh!

hasura-bot commented Feb 20, 2019

Uh oh!

hasura-bot commented Feb 28, 2019

Uh oh!

hasura-bot commented Feb 28, 2019

Uh oh!

hasura-bot commented Feb 28, 2019

Uh oh!

hasura-bot commented Mar 1, 2019

Uh oh!

tirumaraiselvan commented Mar 1, 2019

Uh oh!

hasura-bot commented Mar 1, 2019

Uh oh!

hasura-bot commented Mar 5, 2019

Uh oh!

coco98 commented Mar 5, 2019

Uh oh!

hasura-bot commented Mar 6, 2019

Uh oh!

hasura-bot commented Mar 6, 2019

Uh oh!

praveenweb Mar 6, 2019

Choose a reason for hiding this comment

Uh oh!

praveenweb Mar 6, 2019

Choose a reason for hiding this comment

Uh oh!

praveenweb left a comment

Choose a reason for hiding this comment

Uh oh!

hasura-bot commented Mar 6, 2019

Uh oh!

hasura-bot commented Mar 7, 2019

Uh oh!

hasura-bot commented Mar 7, 2019

Uh oh!

hasura-bot commented Mar 7, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

surendran82 commented Feb 20, 2019 •

edited

Loading