read cookie while initialising websocket connection (fix #1660) #1668
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0x777
requested changes
Feb 27, 2019
Member
0x777
left a comment
There was a problem hiding this comment.
cors validation has to be applied on the host during ws initialisation
- as browsers don't enforce SOP on websockets, we enforce CORS policy on websocket handshake - if CORS is disabled, by default cookie is not read (because XSS risk!). Add special flag to force override this behaviour
rikinsk-zz
previously approved these changes
Feb 28, 2019
shahidhk
requested changes
Feb 28, 2019
Member
shahidhk
left a comment
There was a problem hiding this comment.
@ecthiender Can we show a server log asking to add --ws-read-cookie flag when someone sends a cookie over websocket and cors is disabled?
- add log notice when cors is disabled, and cookie is not read on websocket handshake - forward origin header to webhook in POST mode. So that when CORS is disabled, webhook can also enforce CORS independently.
Resolve Conflicts: .circleci/test-server.sh server/src-exec/Main.hs server/src-lib/Hasura/Server/Init.hs server/tests-py/conftest.py server/tests-py/context.py
Contributor
Author
Done. |
shahidhk
previously approved these changes
Mar 1, 2019
Resolve Conflicts: server/src-exec/Main.hs server/src-lib/Hasura/GraphQL/Transport/WebSocket.hs server/src-lib/Hasura/Server/App.hs server/src-lib/Hasura/Server/Init.hs
0x777
approved these changes
Mar 4, 2019
rikinsk-zz
approved these changes
Mar 4, 2019
Contributor
|
Review app https://hge-ci-pull-1668.herokuapp.com is deleted |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Read cookie (if exists) while initialising websocket connection. If there is auth webhook setup, now authorization over websocket should work seamlessly. (User wouldn't need to read the cookie on the client-side and send it as connection params).
What component does this PR affect?
Requires changes from other components? If yes, please mark the components:
Related Issue
#1660 , #1654
Solution and Design
Type
Checklist: