这是indexloc提供的服务，不要输入任何密码
Skip to content

update console permissions (close #1503, #1529, #1567, #1470) #1605

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 24 commits into from
Feb 17, 2019
Merged

update console permissions (close #1503, #1529, #1567, #1470) #1605

merged 24 commits into from
Feb 17, 2019

Conversation

@rikinsk-zz
Copy link

@rikinsk-zz rikinsk-zz commented Feb 14, 2019 •
edited
Loading

Description

  • show roles from all tables/views in the schema
  • show operators and set values based on field type in permission builder
  • add support for jsonb and postgis operators in permission builder
  • add note for permissions for relationships
  • enable only one Save permissions button if apply to other roles is selected

What component does this PR affect?

  • Server
  • Console
  • CLI
  • Docs
  • Community Content
  • Build System

Requires changes from other components? If yes, please mark the components:

  • Server
  • Console
  • CLI
  • Docs
  • Community Content
  • Build System

Related Issue

#1503, #1529, #1567, #1470

Solution and Design

Type

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Docs update
  • Community content

Checklist:

  • I have read the contributing guide and my code conforms to the guidelines.
  • This change requires a change in the documentation.
  • I have updated the documentation accordingly.
  • I have added required tests.

@rikinsk-zz rikinsk-zz added c/console Related to console s/wip Status: This issue is a work in progress labels Feb 14, 2019
@rikinsk-zz rikinsk-zz added the s/do-not-merge Do not merge this pull request to master label Feb 14, 2019
@rikinsk-zz rikinsk-zz mentioned this pull request Feb 14, 2019
Closed
@rikinsk-zz rikinsk-zz mentioned this pull request Feb 14, 2019
Closed
@rikinsk-zz rikinsk-zz removed s/do-not-merge Do not merge this pull request to master s/wip Status: This issue is a work in progress labels Feb 14, 2019
@hasura-bot
Copy link
Contributor

hasura-bot commented Feb 15, 2019

Review app for commit 0f2ea54 deployed to Heroku: https://hge-ci-pull-1605.herokuapp.com
Docker image for server: hasura/graphql-engine:pull1605-0f2ea54

@hasura-bot
Copy link
Contributor

hasura-bot commented Feb 15, 2019

Review app for commit 4930ad1 deployed to Heroku: https://hge-ci-pull-1605.herokuapp.com
Docker image for server: hasura/graphql-engine:pull1605-4930ad1

@hasura-bot
Copy link
Contributor

hasura-bot commented Feb 16, 2019

Review app for commit ec59e1a deployed to Heroku: https://hge-ci-pull-1605.herokuapp.com
Docker image for server: hasura/graphql-engine:pull1605-ec59e1a

praveenweb
praveenweb requested changes Feb 16, 2019
View reviewed changes
Copy link
Member

@praveenweb praveenweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you revert package-lock.json changes? No package seems to have been added in this PR.

@hasura-bot
Copy link
Contributor

hasura-bot commented Feb 17, 2019

Review app for commit 1b74a5b deployed to Heroku: https://hge-ci-pull-1605.herokuapp.com
Docker image for server: hasura/graphql-engine:pull1605-1b74a5b

@rikinsk-zz rikinsk-zz merged commit 7567485 into hasura:master Feb 17, 2019
@hasura-bot
Copy link
Contributor

hasura-bot commented Feb 17, 2019

Review app https://hge-ci-pull-1605.herokuapp.com is deleted

@rikinsk-zz rikinsk-zz deleted the console-permissions branch February 17, 2019 10:36
@rikinsk-zz rikinsk-zz changed the title update console permissions update console permissions (close #1503, #1529, #1567, #1470) Feb 19, 2019
hasura-bot pushed a commit that referenced this pull request Feb 6, 2025
@rakeshkky @hasura-bot
Fix queries with filters that includes remote relationships from nest…
249552b 
…ed fields (#1605)

<!-- The PR description should answer 2 important questions: -->

### What

Queries with filter expressions that include remote relationships
applied from nested fields were failing. This error arises from
incorrectly assigning the leaf node of a field path as the source column
when the root column in the path should be considered as the source
column.

### How

Treat the first column in the field_path as a source column and append
current column to the nested field path. It is in consistent with the
logic of resolving local field comparison expression.

<!-- How is it trying to accomplish it (what are the implementation
steps)? -->

V3_GIT_ORIGIN_REV_ID: 8abeb1ce964526762524b58b80c05d76b7b657d4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@praveenweb praveenweb praveenweb approved these changes

Assignees

@praveenweb praveenweb

Labels

c/console Related to console

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@rikinsk-zz @hasura-bot @praveenweb @rikinsk @wawhal